Add text-only packages required for 7.0#395
Merged
MichaelSimons merged 2 commits intodotnet:mainfrom Jul 5, 2022
Merged
Conversation
Member
|
Are we sure that CilStrip.Sources doesn't need to be generated at tarball creation time? That version number seems like it's in development and may be updated when net7.0 releases. Alternatively, will this prebuilt go away with this issue being resolved? It seems like the preferable approach to me, unless I'm missing something. This is from a previous investigation we did, I think. dotnet/runtime#69460 The rest of the packages seem OK to me. |
Member
Author
You are correct. This should be resolved by runtime, not SBRP. I will remove this package. |
lbussell
approved these changes
Jul 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds the following text-only packages:
Wcwidth.Sources 0.6.0
Microsoft.Build.NoTargets 3.5.0
Microsoft.Build.Traversal 3.1.6
Microsoft.DotNet.CilStrip.Sources 7.0.0-beta.22313.1This change removs the following text-only packages:
Wcwidth.Sources 0.5.0
Microsoft.Build.NoTargets 3.1.0
Microsoft.Build.Traversal 3.0.23