Fix concurrency issue in the referencePackageSourceGenerator#359
Merged
MichaelSimons merged 2 commits intodotnet:mainfrom Mar 16, 2022
Merged
Fix concurrency issue in the referencePackageSourceGenerator#359MichaelSimons merged 2 commits intodotnet:mainfrom
MichaelSimons merged 2 commits intodotnet:mainfrom
Conversation
lbussell
approved these changes
Mar 15, 2022
Member
lbussell
left a comment
There was a problem hiding this comment.
Thanks for diagnosing this. I've hit this before too but didn't know what to investigate/thought it was user error.
src/referencePackageSourceGenerator/GenerateProjects/GenerateProjects.proj
Outdated
Show resolved
Hide resolved
1055005 to
c15a5b7
Compare
c15a5b7 to
b41499c
Compare
crummel
approved these changes
Mar 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The logic that replaces the assembly attributes placeholder in GenerateProjects was running before GenerateSource completed. This causes the generated source to be incorrect.
This was encountered with #357.