Add version 4.8.1 of System.Reflection.DispatchProxy and 6.1.1 of System.Runtime.CompilerServices.Unsafe#1151
Add version 4.8.1 of System.Reflection.DispatchProxy and 6.1.1 of System.Runtime.CompilerServices.Unsafe#1151MichaelSimons merged 6 commits intodotnet:mainfrom carlossanlop:UpdateMP
Conversation
Yes because we need the ability to generate the checked in packages overtime. |
NuGet.config
Outdated
| </fallbackPackageFolders> | ||
| <packageSources> | ||
| <clear /> | ||
| <add key="darc-pub-dotnet-maintenance-packages-f9ed1720" value="https://dnceng.pkgs.visualstudio.com/public/_packaging/darc-pub-dotnet-maintenance-packages-f9ed1720/nuget/v3/index.json" /> |
There was a problem hiding this comment.
This should be moved to the other darc feed. It would be helpful to add a comment like the other feed as well.
There was a problem hiding this comment.
Sorry, can you elaborate?
There was a problem hiding this comment.
Sorry my wording was poor. Please move it next to the other existing darc feed - https://github.com/dotnet/source-build-reference-packages/blob/main/NuGet.config#L24
There was a problem hiding this comment.
Ah! Sure, will do.
| @@ -0,0 +1,8 @@ | |||
| <Project Sdk="Microsoft.NET.Sdk"> | |||
There was a problem hiding this comment.
This project will need to be added to https://github.com/dotnet/source-build-reference-packages/blob/main/eng/Build.props#L45 per the instructions
Add DependencyPackageProjects for all new projects in the [eng/Build.props](https://github.com/dotnet/source-build-reference-packages/blob/main/eng/Build.props#L9) in the correct dependency order.
I take it the package isn't referenced in the SB graph given your VMR validation was green. |
Move nuget.config key to the bottom with a comment.
|
Should we merge this before all the other PRs? I think this one would not break the sdk deps flow if we merge it first. Edit: Need some clarification from my team offline. Making it draft for now. |
Correct, This is additive so it can be merged ahead of the incoming changes. |
|
Once you mark it as ready for review, I will go ahead and merge it. |
Oops, fixed. Thanks! |
|
Wait, let me update the feed. I had to generate a new version for a new package. |
|
Okay! Ready. I updated the feed to the latest, then I added System.Runtime.CompilerServices and also added the recently updated System.Reflection.DispatchProxy to the repo and updated build.props. As previously mentioned, System.ValueTuple is not getting added by generate.sh. |
This PR is result of testing the parallel dependency updates to ensure source-build does not break: dotnet/dotnet#133
System.ValueTuple did not generate anything when running generate.sh against it:
IMPORTANT: I need to merge this PR at the same time as all the other PRs in the other repos, to prevent breaking the dependency ingestion in the dotnet/sdk repo.
@MichaelSimons Please remind me if we need to include the feed or not.