Enable building on arm64 by omajid · Pull Request #1300 · dotnet/source-build

omajid · 2019-10-09T17:20:04Z

With this change, I can build source-build on RHEL 8 on arm64:

$ ~/source-build/dotnet-sdk/dotnet --info                                                                                                                                                                      
.NET Core SDK (reflecting any global.json):                                                                                                                                                                                                   
 Version:   3.0.100                                                                                                                                                                                                                           
 Commit:    04339c3a26                                                                                                                                                                                                                        
                                                                                                                                                                                                                                              
Runtime Environment:                                                                                                                                                                                                                          
 OS Name:     rhel                                                                                                                                                                                                                            
 OS Version:  8                                                                                                                                                                                                                               
 OS Platform: Linux                                                                                                                                                                                                                           
 RID:         rhel.8-arm64                                                                                                                                                                                                                    
 Base Path:   /home/omajid/source-build/dotnet-sdk/sdk/3.0.100/                                                                                                                                                                               
                                                                                                                                                                                                                                              
Host (useful for support):                                                                                                                                                                                                                    
  Version: 3.0.0                                                                                                                                                                                                                              
  Commit:  62f8ee7211                                                                                                                                                                                                                         
                                                                                                                                                                                                                                              
.NET Core SDKs installed:                                                                                                                                                                                                                     
  3.0.100 [/home/omajid/source-build/dotnet-sdk/sdk]                                                                                                                                                                                          
                                                                                                                                                                                                                                              
.NET Core runtimes installed:                                                                                                                                                                                                                 
  Microsoft.AspNetCore.App 3.0.0 [/home/omajid/source-build/dotnet-sdk/shared/Microsoft.AspNetCore.App]                                                                                                                                       
  Microsoft.NETCore.App 3.0.0 [/home/omajid/source-build/dotnet-sdk/shared/Microsoft.NETCore.App]                                                                                                                                             
                                                                                                                                                                                                                                              
To install additional .NET Core runtimes or SDKs:                                                                                                                                                                                             
  https://aka.ms/dotnet-download                                                                                                                                                                                                              
$ ~/source-build/dotnet-sdk/dotnet new console                                                                                                                                                                 
The template "Console Application" was created successfully.                                                                                                                                                                                  
                                                                                                                                                                                                                                              
Processing post-creation actions...                                                                                                                                                                                                           
Running 'dotnet restore' on /home/omajid/source-build/hello/hello.csproj...                                                                                                                                                                   
  Restore completed in 122.02 ms for /home/omajid/source-build/hello/hello.csproj.                                                                                                                                                            
                                                                                                                                                                                                                                              
Restore succeeded.                                                                                                                                                                                                                            
                                                                                                                                                                                                                                              
$ ~/source-build/dotnet-sdk/dotnet run                                                                                                                                                                         
Hello World!

~~I also needed this change to arcade-services:~~ The following is redundant because the arcade-services submodule was removed:

diff --git a/tools-local/arcade-services/eng/Versions.props b/tools-local/arcade-services/eng/Versions.props
index c69a2ff..6350ff1 100644
--- a/tools-local/arcade-services/eng/Versions.props
+++ b/tools-local/arcade-services/eng/Versions.props
@@ -12,7 +12,7 @@
     <CommandLineParserVersion>2.2.1</CommandLineParserVersion>
     <CredentialManagementVersion>1.0.2</CredentialManagementVersion>
     <HandlebarsNetVersion>1.9.5</HandlebarsNetVersion>
-    <LibGit2SharpVersion>0.26.0</LibGit2SharpVersion>
+    <LibGit2SharpVersion>0.27.0-preview-0020</LibGit2SharpVersion>
     <log4netVersion>2.0.8</log4netVersion>
     <SystemNetHttpVersion>4.3.3</SystemNetHttpVersion>
     <MicrosoftAzureKeyVaultVersion>3.0.3</MicrosoftAzureKeyVaultVersion>

Some open questions:

I am working on opening PRs to get these patches merged in the orginial repos. What should I do for the release/3.0 and release/3.1 branches? Should I try and get the fixes in the original repos too? Or is it okay to carry these patches for 3.0 and 3.1?
There's a ton of hardcoded x64 assumptions. Is there a longer term plan to fix them? Is this something I need to look into?
There's a number of assumptions that cross compile and arm mean that the tools building this are x64 (only).

Any thoughts or comments?

patches/aspnetcore/aspnetcore-arm64.patch

repos/coreclr.proj

patches/core-sdk/0001-Enable-building-on-arm64-machines.patch

patches/core-setup/8468.patch

patches/corefx/40453.patch

omajid · 2019-11-07T17:52:11Z

build-source-tarball.sh

+    buildArch=x64
+    ;;
+esac
+


I got this chunk from here: dotnet/arcade#4132

patches/aspnetcore/aspnetcore-arm64.patch

omajid · 2019-11-11T20:12:47Z

@dleeapho @dseefeld Should I target this PR against release/3.1 instead of release/3.0?

crummel · 2019-11-11T22:47:19Z

@adaggarwal is working on merging 3.0 to 3.1 (#1355), after that 3.1 will be our primary development branch. I think this is okay to stay against release/3.0, after 3.0.1 (#1260) is in we'll take this and add it to the 3.1 merge - if that sounds good to you Aditya?

adaggarwal · 2019-11-11T22:49:11Z

@adaggarwal Aditya Aggarwal FTE is working on merging 3.0 to 3.1 (#1355), after that 3.1 will be our primary development branch. I think this is okay to stay against release/3.0, after 3.0.1 (#1260) is in we'll take this and add it to the 3.1 merge - if that sounds good to you Aditya?

Yep. That sounds reasonable.

omajid · 2019-11-12T19:26:49Z

repos/aspnetcore.proj

    <BuildCommandArgs>$(BuildCommandArgs) --ci</BuildCommandArgs>
    <BuildCommandArgs>$(BuildCommandArgs) -bl</BuildCommandArgs>
+    <BuildCommandArgs>$(BuildCommandArgs) -bl</BuildCommandArgs>
+    <BuildCommandArgs>$(BuildCommandArgs) --arch $(Platform)</BuildCommandArgs>


I tried using TargetArchitecture but we call ./build.sh which actually passes -p:TargetArchitecture=x64 unless we set --arch

patches/aspnetcore/0009-Support-global.json-on-arm64-as-well.patch

patches/aspnetcore/0010-Support-building-for-arm64-on-arm64-nix.patch

omajid · 2019-11-12T20:05:50Z

I rebased it onto the latest release/3.0 and I am running into a new issue. Darc seems to use an older version of libgit2sharp and wont run on RHEL 8 arm64 at all 😞

crummel · 2019-11-12T20:22:12Z

I think that should be a reasonably easy fix, Darc needs the update here and then we can change our Darc version.

omajid · 2019-11-12T22:17:28Z

The version here should already be correct. How do I find out what darc version that is included in? Currently, source-build pulls down this version:

Tool 'microsoft.dotnet.darc' (version '1.1.0-beta.19515.3') was successfully installed.

omajid · 2019-11-12T22:54:55Z

Oh, right, I can just put the new version in DarcVersion.txt. I tried out dotnet tool install and it tells me:

- Found 89 version(s) in https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-tools/nuget/v3/index.json [ Nearest version: 1.1.0-beta.19557.3 ]

I tried it out but even 1.1.0-beta.19557.3 doesn't seem to have the fix :(

crummel · 2019-11-18T23:42:00Z

Sounds like it was just two PRs going in without being tested against each other, should be fixed after #1365 goes in.

omajid · 2019-11-20T19:36:38Z

I have rebased this against the release/3.1 branch to pick up the darc fixes.

omajid · 2019-11-20T23:11:35Z

@dleeapho @crummel @dseefeld All my local testing looks good. CI seems happy too. What are the next steps here?

crummel

There's one thing I want to look into quick but this is looking good to me.

crummel · 2019-11-20T23:16:08Z

patches/core-sdk/0003-Enable-building-on-arm64-machines.patch

+     <DotnetDebToolVersion>2.0.0</DotnetDebToolVersion>
+     <MicrosoftNETTestSdkVersion>15.8.0</MicrosoftNETTestSdkVersion>
+-    <MicrosoftSourceLinkVersion>1.0.0-beta2-18618-05</MicrosoftSourceLinkVersion>
+    <MicrosoftSourceLinkVersion>1.0.0-beta2-19367-01</MicrosoftSourceLinkVersion>


This is interesting - this version should be getting overridden by our built SourceLink version anyway. I'll take a look at that.

I added the entire git format-patch from the core-sdk PR: dotnet/installer#4102. It could very well be that source-build doesn't care about this property. Do you want me to test out removing this? Or leave as it is, like the change that was merged into core-sdk?

Btw, the same applies for all the new patches added by this PR. They are the git format-patch output from the individual repos, tweaked to apply to source-build's release/3.1, but without any other changes.

I checked and the override is working in my local build, so we must have a new enough version of SourceLink in source-build if this is working for you. I updated it not too long ago so that makes sense. I'd prefer leaving this change out if we can just because version properties like this tend to conflict quite a bit.

Okay. I am sold!

omajid · 2019-11-20T23:31:44Z

dir.props

    <ExtraPackageVersionPropsPackageInfo Include="MicrosoftNETCoreAppRuntimeVersion" Version="%24(MicrosoftNETCoreDotNetAppHostPackageVersion)" />
    <ExtraPackageVersionPropsPackageInfo Include="MicrosoftNETCoreAppHostPackageVersion" Version="%24(MicrosoftNETCoreDotNetAppHostPackageVersion)" />
-    <ExtraPackageVersionPropsPackageInfo Include="MicrosoftAspNetCoreAppRuntimePackageVersion" Version="%24(MicrosoftAspNetCoreAppRuntimeLinuxX64PackageVersion)" />
+    <ExtraPackageVersionPropsPackageInfo Include="MicrosoftAspNetCoreAppRuntimePackageVersion" Version="%24(MicrosoftAspNetCoreAppRuntimeLinux$(Platform)PackageVersion)" />


There is a change in capitalization here. It goes from ...X64... to ...x64.... But msbuild properties are case in-sensitive, so it doesn't result in a functional change.

omajid · 2019-11-20T23:32:40Z

patches/aspnetcore/0011-Support-global.json-on-arm64-as-well.patch

+From 84d274a8f3d416b0a5bd999e3d1c43ae1535e38f Mon Sep 17 00:00:00 2001
+From: Omair Majid <omajid@redhat.com>
+Date: Wed, 23 Oct 2019 15:43:57 -0400
+Subject: [PATCH] Support global.json on arm64 as well


This is dotnet/aspnetcore#14790.

omajid · 2019-11-20T23:33:03Z

patches/aspnetcore/0012-Support-building-for-arm64-on-arm64-nix.patch

+From e2946a26c11be7f7f0c223721a5b14f58f2ea240 Mon Sep 17 00:00:00 2001
+From: Omair Majid <omajid@redhat.com>
+Date: Mon, 11 Nov 2019 13:37:40 -0500
+Subject: [PATCH] Support building for arm64 on arm64 (*nix)


This is dotnet/aspnetcore#15354

omajid · 2019-11-20T23:33:28Z

patches/core-sdk/0003-Enable-building-on-arm64-machines.patch

+From 4b5c617203cfb9d2c1b12995e12d819fba6d7b6f Mon Sep 17 00:00:00 2001
+From: Omair Majid <omajid@redhat.com>
+Date: Tue, 8 Oct 2019 17:02:29 -0400
+Subject: [PATCH] Enable building on arm64 machines


This is dotnet/installer#4102

omajid · 2019-11-20T23:33:51Z

patches/core-setup/0004-Enable-building-for-arm64-on-arm64.patch

+From c02027bfee1c523006430183d37c1b61072d5ed8 Mon Sep 17 00:00:00 2001
+From: Omair Majid <omajid@redhat.com>
+Date: Fri, 4 Oct 2019 16:08:59 -0400
+Subject: [PATCH] Enable building for arm64 on arm64


This is dotnet/core-setup#8468

omajid · 2019-11-20T23:34:10Z

patches/corefx/0004-Enable-build-on-hosted-arm64.patch

+From d36274c31cc30a946c023b7a5bb5c6fa1ff86625 Mon Sep 17 00:00:00 2001
+From: Omair Majid <omajid@redhat.com>
+Date: Tue, 20 Aug 2019 13:40:19 -0400
+Subject: [PATCH] Enable build on hosted arm64


This is dotnet/corefx#40453

This change allows source-build to be cloned and built on arm64 machines. It shouldn't affect cross compilation at all, however. I have tested this on RHEL 8 aarch64. This change includes backports of the following pull-requests which have been merged into their respective master branches: - dotnet/aspnetcore#14790 - dotnet/aspnetcore#15354 - dotnet/installer#4102 - dotnet/core-setup#8468 - dotnet/corefx#40453 There's a number of existing build configuration that are conditionalized on arm64, such as setting up a root file system. Those they are actually only meant to be invoked when cross-compiling for arm64 (on x86_64). This commit modifies those conditions to not apply when building on an arm64 machine.

crummel · 2019-11-22T02:55:21Z

Rebased on the 3.0 => 3.1 merge, it was pretty clean but let me know if anything looks weird.

omajid · 2019-11-22T15:23:31Z

~~Quick update: rebase completely broke everything :( Aside from patches not applying, looks like we are back to an older version of darc that doesn't work on rhel.8-arm64.~~

Nvm, looks like network issues, I think I misread the error messages.

crummel · 2019-11-22T16:22:47Z

Sorry about that, I think I fixed the patches now.

omajid · 2019-11-22T16:27:14Z

Thanks! I am going to try out this locally on an arm64 box.

crummel · 2019-11-22T19:52:08Z

The OSX failure is expected so we can merge this as soon as it looks good to you @omajid.

omajid · 2019-11-22T21:24:03Z

I am seeing core-sdk builds failures on my machine. Not sure why.

  /home/omajid/source-build/bin/src/core-sdk.cd82f021f4c2c8901bd7975fcaefc34fdeec3ded/src/redist/targets/GenerateLayout.targets(351,5): error MSB4018: The "DownloadFile" task failed unexpectedly. [/home/omajid/source-build/bin/src/core-sdk.cd82f021f4c2c8901bd7975fcaefc34fdeec3ded/src/redist/redist.csproj]                                                                                                                                                                          
  /home/omajid/source-build/bin/src/core-sdk.cd82f021f4c2c8901bd7975fcaefc34fdeec3ded/src/redist/targets/GenerateLayout.targets(351,5): error MSB4018: System.IO.DirectoryNotFoundException: Could not find a part of the path '/home/omajid/source-build/bin/obj/arm64/Release/blobs/Toolset/3.1.100-rtm.19566.4/dotnet-toolset-internal-3.1.100-rtm.19566.4.zip'. [/home/omajid/source-build/bin/src/core-sdk.cd82f021f4c2c8901bd7975fcaefc34fdeec3ded/src/redist/redist.csproj]          
  /home/omajid/source-build/bin/src/core-sdk.cd82f021f4c2c8901bd7975fcaefc34fdeec3ded/src/redist/targets/GenerateLayout.targets(351,5): error MSB4018:    at Interop.ThrowExceptionForIoErrno(ErrorInfo errorInfo, String path, Boolean isDirectory, Func`2 errorRewriter) [/home/omajid/source-build/bin/src/core-sdk.cd82f021f4c2c8901bd7975fcaefc34fdeec3ded/src/redist/redist.csproj]                                                                                                   
  /home/omajid/source-build/bin/src/core-sdk.cd82f021f4c2c8901bd7975fcaefc34fdeec3ded/src/redist/targets/GenerateLayout.targets(351,5): error MSB4018:    at Microsoft.Win32.SafeHandles.SafeFileHandle.Open(String path, OpenFlags flags, Int32 mode) [/home/omajid/source-build/bin/src/core-sdk.cd82f021f4c2c8901bd7975fcaefc34fdeec3ded/src/redist/redist.csproj]                                                                                                                       
  /home/omajid/source-build/bin/src/core-sdk.cd82f021f4c2c8901bd7975fcaefc34fdeec3ded/src/redist/targets/GenerateLayout.targets(351,5): error MSB4018:    at System.IO.FileStream.OpenHandle(FileMode mode, FileShare share, FileOptions options) [/home/omajid/source-build/bin/src/core-sdk.cd82f021f4c2c8901bd7975fcaefc34fdeec3ded/src/redist/redist.csproj]                                                                                                                            
  /home/omajid/source-build/bin/src/core-sdk.cd82f021f4c2c8901bd7975fcaefc34fdeec3ded/src/redist/targets/GenerateLayout.targets(351,5): error MSB4018:    at System.IO.FileStream..ctor(String path, FileMode mode, FileAccess access, FileShare share, Int32 bufferSize, FileOptions options) [/home/omajid/source-build/bin/src/core-sdk.cd82f021f4c2c8901bd7975fcaefc34fdeec3ded/src/redist/redist.csproj]                                                                               
  /home/omajid/source-build/bin/src/core-sdk.cd82f021f4c2c8901bd7975fcaefc34fdeec3ded/src/redist/targets/GenerateLayout.targets(351,5): error MSB4018:    at System.IO.FileSystem.CopyFile(String sourceFullPath, String destFullPath, Boolean overwrite) [/home/omajid/source-build/bin/src/core-sdk.cd82f021f4c2c8901bd7975fcaefc34fdeec3ded/src/redist/redist.csproj]                                                                                                                    
  /home/omajid/source-build/bin/src/core-sdk.cd82f021f4c2c8901bd7975fcaefc34fdeec3ded/src/redist/targets/GenerateLayout.targets(351,5): error MSB4018:    at System.IO.File.Copy(String sourceFileName, String destFileName, Boolean overwrite) [/home/omajid/source-build/bin/src/core-sdk.cd82f021f4c2c8901bd7975fcaefc34fdeec3ded/src/redist/redist.csproj]                                                                                                                              
  /home/omajid/source-build/bin/src/core-sdk.cd82f021f4c2c8901bd7975fcaefc34fdeec3ded/src/redist/targets/GenerateLayout.targets(351,5): error MSB4018:    at System.IO.File.Copy(String sourceFileName, String destFileName) [/home/omajid/source-build/bin/src/core-sdk.cd82f021f4c2c8901bd7975fcaefc34fdeec3ded/src/redist/redist.csproj]                                                                                                                                                 
  /home/omajid/source-build/bin/src/core-sdk.cd82f021f4c2c8901bd7975fcaefc34fdeec3ded/src/redist/targets/GenerateLayout.targets(351,5): error MSB4018:    at Microsoft.DotNet.Cli.Build.DownloadFile.Execute() in /_/src/core-sdk-tasks/DownloadFile.cs:line 41 [/home/omajid/source-build/bin/src/core-sdk.cd82f021f4c2c8901bd7975fcaefc34fdeec3ded/src/redist/redist.csproj]                                                                                                              
  /home/omajid/source-build/bin/src/core-sdk.cd82f021f4c2c8901bd7975fcaefc34fdeec3ded/src/redist/targets/GenerateLayout.targets(351,5): error MSB4018:    at Microsoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute() [/home/omajid/source-build/bin/src/core-sdk.cd82f021f4c2c8901bd7975fcaefc34fdeec3ded/src/redist/redist.csproj]                                                                                                                  
  /home/omajid/source-build/bin/src/core-sdk.cd82f021f4c2c8901bd7975fcaefc34fdeec3ded/src/redist/targets/GenerateLayout.targets(351,5): error MSB4018:    at Microsoft.Build.BackEnd.TaskBuilder.ExecuteInstantiatedTask(ITaskExecutionHost taskExecutionHost, TaskLoggingContext taskLoggingContext, TaskHost taskHost, ItemBucket bucket, TaskExecutionMode howToExecuteTask) [/home/omajid/source-build/bin/src/core-sdk.cd82f021f4c2c8901bd7975fcaefc34fdeec3ded/src/redist/redist.csproj]                                                                                                                                                                                                                                            
      0 Warning(s)                                                                                                                                                                                                                            
      1 Error(s)

Looks like /home/omajid/source-build/bin/obj/arm64/Release/blobs/Toolset/ doesn't even exist.

omajid · 2019-11-22T21:36:38Z

Actually, looks like the toolset build failed (flaky network?) and error cascaded on:

  Failed to download package 'Microsoft.Docker.Sdk.1.1.0' from 'https://www.myget.org/F/container-tools-for-visual-studio/api/v3/flatcontainer/microsoft.docker.sdk/1.1.0/microsoft.docker.sdk.1.1.0.nupkg'.
  The HTTP request to 'GET https://www.myget.org/F/container-tools-for-visual-studio/api/v3/flatcontainer/microsoft.docker.sdk/1.1.0/microsoft.docker.sdk.1.1.0.nupkg' has timed out after 100000ms.
  Failed to download package 'Microsoft.Docker.Sdk.1.1.0' from 'https://www.myget.org/F/container-tools-for-visual-studio/api/v3/flatcontainer/microsoft.docker.sdk/1.1.0/microsoft.docker.sdk.1.1.0.nupkg'.
  The HTTP request to 'GET https://www.myget.org/F/container-tools-for-visual-studio/api/v3/flatcontainer/microsoft.docker.sdk/1.1.0/microsoft.docker.sdk.1.1.0.nupkg' has timed out after 100000ms.
/home/omajid/source-build/.dotnet/sdk/3.1.100-preview1-014459/NuGet.targets(123,5): error : Failed to download package 'Microsoft.Docker.Sdk.1.1.0' from 'https://www.myget.org/F/container-tools-for-visual-studio/api/v3/flatcontainer/microsoft.docker.sdk/1.1.0/microsoft.docker.sdk.1.1.0.nupkg'. [/home/omajid/source-build/bin/src/toolset.575b1c9f9636e57881fc41817d3f049dff6ff470/src/redist/targets/sdks/sdks.csproj]
/home/omajid/source-build/.dotnet/sdk/3.1.100-preview1-014459/NuGet.targets(123,5): error : The HTTP request to 'GET https://www.myget.org/F/container-tools-for-visual-studio/api/v3/flatcontainer/microsoft.docker.sdk/1.1.0/microsoft.docker.sdk.1.1.0.nupkg' has timed out after 100000ms. [/home/omajid/source-build/bin/src/toolset.575b1c9f9636e57881fc41817d3f049dff6ff470/src/redist/targets/sdks/sdks.csproj]
##vso[task.logissue type=error;sourcepath=/home/omajid/source-build/.dotnet/sdk/3.1.100-preview1-014459/NuGet.targets;linenumber=123;columnnumber=5;code=;]Failed to download package 'Microsoft.Docker.Sdk.1.1.0' from 'https://www.myget.org/F/container-tools-for-visual-studio/api/v3/flatcontainer/microsoft.docker.sdk/1.1.0/microsoft.docker.sdk.1.1.0.nupkg'.%0AThe HTTP request to 'GET https://www.myget.org/F/container-tools-for-visual-studio/api/v3/flatcontainer/microsoft.docker.sdk/1.1.0/microsoft.docker.sdk.1.1.0.nupkg' has timed out after 100000ms.
/home/omajid/source-build/.dotnet/sdk/3.1.100-preview1-014459/NuGet.targets(123,5): error : The feed 'container-tools [https://www.myget.org/F/container-tools-for-visual-studio/api/v3/index.json]' lists package 'Microsoft.Docker.Sdk.1.1.0' but multiple attempts to download the nupkg have failed. The feed is either invalid or required packages were removed while the current operation was in progress. Verify the package exists on the feed and try again. [/home/omajid/source-build/bin/src/toolset.575b1c9f9636e57881fc41817d3f049dff6ff470/src/redist/targets/sdks/sdks.csproj]
/home/omajid/source-build/.dotnet/sdk/3.1.100-preview1-014459/NuGet.targets(123,5): error :   Unable to find package 'Microsoft.Docker.Sdk.1.1.0'. [/home/omajid/source-build/bin/src/toolset.575b1c9f9636e57881fc41817d3f049dff6ff470/src/redist/targets/sdks/sdks.csproj]
##vso[task.logissue type=error;sourcepath=/home/omajid/source-build/.dotnet/sdk/3.1.100-preview1-014459/NuGet.targets;linenumber=123;columnnumber=5;code=;]The feed 'container-tools [https://www.myget.org/F/container-tools-for-visual-studio/api/v3/index.json%5D' lists package 'Microsoft.Docker.Sdk.1.1.0' but multiple attempts to download the nupkg have failed. The feed is either invalid or required packages were removed while the current operation was in progress. Verify the package exists on the feed and try again.%0A  Unable to find package 'Microsoft.Docker.Sdk.1.1.0'.
  Restore completed in 17.96 ms for /home/omajid/source-build/bin/src/toolset.575b1c9f9636e57881fc41817d3f049dff6ff470/src/redist/targets/sdks/sdks.csproj.
  Copied Sdk ILLink.Tasks from /home/omajid/source-build/packages/restored//illink.tasks/0.1.6-prerelease.19380.1 to /home/omajid/source-build/bin/src/toolset.575b1c9f9636e57881fc41817d3f049dff6ff470/artifacts/bin/redist/Release/netcoreapp3.1//Sdks/ILLink.Tasks.
  Successfully created package '/home/omajid/source-build/bin/src/toolset.575b1c9f9636e57881fc41817d3f049dff6ff470/artifacts/packages/Release/NonShipping/Microsoft.Dotnet.Toolset.Internal.3.1.100-rtm.19566.4.nupkg'.

Build succeeded.

/home/omajid/source-build/.dotnet/sdk/3.1.100-preview1-014459/NuGet.targets(123,5): error : Failed to download package 'Microsoft.Docker.Sdk.1.1.0' from 'https://www.myget.org/F/container-tools-for-visual-studio/api/v3/flatcontainer/microsoft.docker.sdk/1.1.0/microsoft.docker.sdk.1.1.0.nupkg'. [/home/omajid/source-build/bin/src/toolset.575b1c9f9636e57881fc41817d3f049dff6ff470/src/redist/targets/sdks/sdks.csproj]
/home/omajid/source-build/.dotnet/sdk/3.1.100-preview1-014459/NuGet.targets(123,5): error : The HTTP request to 'GET https://www.myget.org/F/container-tools-for-visual-studio/api/v3/flatcontainer/microsoft.docker.sdk/1.1.0/microsoft.docker.sdk.1.1.0.nupkg' has timed out after 100000ms. [/home/omajid/source-build/bin/src/toolset.575b1c9f9636e57881fc41817d3f049dff6ff470/src/redist/targets/sdks/sdks.csproj]
/home/omajid/source-build/.dotnet/sdk/3.1.100-preview1-014459/NuGet.targets(123,5): error : The feed 'container-tools [https://www.myget.org/F/container-tools-for-visual-studio/api/v3/index.json]' lists package 'Microsoft.Docker.Sdk.1.1.0' but multiple attempts to download the nupkg have failed. The feed is either invalid or required packages were removed while the current operation was in progress. Verify the package exists on the feed and try again. [/home/omajid/source-build/bin/src/toolset.575b1c9f9636e57881fc41817d3f049dff6ff470/src/redist/targets/sdks/sdks.csproj]
/home/omajid/source-build/.dotnet/sdk/3.1.100-preview1-014459/NuGet.targets(123,5): error :   Unable to find package 'Microsoft.Docker.Sdk.1.1.0'. [/home/omajid/source-build/bin/src/toolset.575b1c9f9636e57881fc41817d3f049dff6ff470/src/redist/targets/sdks/sdks.csproj]
    0 Warning(s)
    2 Error(s)

Time Elapsed 00:05:53.45

omajid · 2019-11-22T23:04:51Z

Sorry about the noise. Everything looks good here. 👍 to merge this.

crummel · 2019-11-24T15:57:56Z

Awesome, thanks for doing this!

tmds · 2019-11-25T08:02:47Z

🎉 🎉 🎉