Merged
Conversation
erdembayar
approved these changes
Dec 1, 2025
pjcollins
approved these changes
Dec 1, 2025
a7217cd to
ea59b25
Compare
This was referenced Feb 9, 2026
This was referenced Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve #956
This change fixes an intermittent
IOExceptioninCrypt32Tests.ShouldTimestampDatawhere the test attempted to read the test timestamp server's log file before it was fully closed. This eliminates the race condition where tests could access files still held open by the timestamp service.RespondAsync(...)truly async with asyncTaskandawaitin finally blockWriteAsync(...)method usingawait usingand async write operations