Add RecurseContainers option for signing process#895
Merged
Conversation
c2dc770 to
5dd0f90
Compare
dtivel
reviewed
Jun 19, 2025
Collaborator
dtivel
left a comment
There was a problem hiding this comment.
Minor changes requested. Looks great.
test/Sign.Core.Test/DataFormatSigners/AzureSignToolSignerTests.cs
Outdated
Show resolved
Hide resolved
test/Sign.Core.Test/DataFormatSigners/AggregatingSignerTests.Containers.cs
Outdated
Show resolved
Hide resolved
test/Sign.Core.Test/DataFormatSigners/AggregatingSignerTests.Containers.cs
Outdated
Show resolved
Hide resolved
test/Sign.Core.Test/DataFormatSigners/AggregatingSignerTests.Containers.cs
Outdated
Show resolved
Hide resolved
test/Sign.Core.Test/DataFormatSigners/AggregatingSignerTests.Containers.cs
Outdated
Show resolved
Hide resolved
test/Sign.Core.Test/DataFormatSigners/AggregatingSignerTests.Containers.cs
Outdated
Show resolved
Hide resolved
dtivel
approved these changes
Jun 23, 2025
This commit introduces a new `RecurseContainers` option that allows users to specify whether to sign the contents of container files recursively. This is enabled by default, but can be disabled using `--recurse-containers=false`. Disabling this feature will prevent sign tool from signing files in containers such as `appx`, but will still sign the `appx` file itself.
Co-authored-by: Damon Tivel <dtivel@microsoft.com>
Add parm names to test
0e1fa36 to
cbdd652
Compare
haritha-mohan
approved these changes
Jun 25, 2025
pjcollins
approved these changes
Jun 25, 2025
|
🎉 Thank you! |
Merged
This was referenced Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new
--recurse-containers/-rcoption that allows users to specify whether to sign the contents of container files recursively.This is enabled by default but can be disabled using
--recurse-containers=false.Disabling this feature will prevent sign tool from signing files in containers such as
appxbut will still sign theappxfile itself. This is useful for those who sign their files before packaging them into a container.Fixes #775