Merged
Conversation
dlemstra
reviewed
Apr 2, 2025
jeffkl
approved these changes
Apr 2, 2025
jeffkl
left a comment
There was a problem hiding this comment.
If every test needs a TemporaryDirectory, consider adding a base class that all tests inherit from which gets a lazy temp directory and disposes of it. That way all tests would follow the same pattern.
Collaborator
Author
|
@jeffkl, thanks for the feedback. Not every test needs a |
erdembayar
approved these changes
Apr 3, 2025
joelverhagen
approved these changes
Apr 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change ensures that the
DirectoryServiceis properly disposed of after use. This ensures test files are deleted after test execution.Also, some very minor reformatting changes.
Use https://github.com/dotnet/sign/pull/845/files?w=1 to ignore whitespace changes.