VSIX: fix signature timestamp format string bug#839
Merged
Conversation
joelverhagen
approved these changes
Mar 29, 2025
erdembayar
approved these changes
Mar 31, 2025
8087594 to
4f796a0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve #837.
By default,
DateTimeOffset.ToString(string)uses the current culture. For en-DK, the time separator is.not:. So, the result is a value which doesn't follow the OPC signature timestamp format.This change forces the
DateTimeOffset.ToString(...)call to useCultureInfo.InvariantCulture. This produces the expected result regardless of the current culture.