Skip to content

NuGetSigner ignores SignAsync return value #798

@zooba

Description

@zooba

When signing a nupkg fails, RetryingSigner.SignAsync returns false.

However, the NuGetSigner (subclass) which calls this function ignores the result.

As a result, the sign tool exits with exit code 0 and the caller does not know that signing has failed.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Priority:1Work that is critical for the release, but we could probably ship withoutarea-nugetRelated to NuGet signingarea-vsixRelated to VSIX signingbug

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions