Fix static lock in TestApplicationActionQueue#53304
Merged
Evangelink merged 1 commit intomainfrom Mar 9, 2026
Merged
Conversation
Change _lock from static to instance field. The lock protects instance state (_aggregateExitCode) so it should be scoped to the instance. A static lock incorrectly serializes exit code aggregation across all instances.
3 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in TestApplicationActionQueue where the _lock field was declared static, causing all instances of the class to share the same lock. Since _lock only protects instance-level state (_aggregateExitCode), the lock should be scoped to each instance. Making it non-static eliminates unnecessary cross-instance contention and correctly limits the lock's scope to the data it protects.
Changes:
- Removed
staticfrom the_lockfield declaration inTestApplicationActionQueue
Youssef1313
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
_lockinTestApplicationActionQueuefromstaticto an instance field.Problem
The
_lockfield isstatic, meaning allTestApplicationActionQueueinstances share the same lock. However, the lock protects instance state (_aggregateExitCode), so it should be scoped to the instance. A static lock incorrectly serializes exit code aggregation across all instances, which would cause unnecessary contention if multiple instances were ever created (e.g., in tests or future refactoring).Changes
src/Cli/dotnet/Commands/Test/MTP/TestApplicationActionQueue.cs:static readonly Lock _lock→readonly Lock _lock