Fix build break from concurrent changes w/api breaking change#52817
Merged
MichaelSimons merged 1 commit intodotnet:mainfrom Feb 3, 2026
Merged
Fix build break from concurrent changes w/api breaking change#52817MichaelSimons merged 1 commit intodotnet:mainfrom
MichaelSimons merged 1 commit intodotnet:mainfrom
Conversation
baronfel
approved these changes
Feb 3, 2026
marcpopMSFT
approved these changes
Feb 3, 2026
JeremyKuhne
approved these changes
Feb 3, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR resolves a build break caused by concurrent merges of two pull requests: PR #52757 (which refactored _testAssetsManager field to TestAssetsManager property) and PR #51962 (which added new tests using the old field name). The fix updates the two new test methods to use the renamed property.
Changes:
- Updated references from
_testAssetsManagertoTestAssetsManagerin two test methods added by PR #51962
Member
Author
|
Force merging to address build break to unblock other work. The macOS (arm64) leg completed the build step which validates the build break was addressed. |
This was referenced Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was caused by the breaking change in #52757 and #51962 being merged without updating to latest.