sdk tasks migration to the ThreadSafe attribute, simple tasks, part 2#52555
Merged
sdk tasks migration to the ThreadSafe attribute, simple tasks, part 2#52555
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Marks a set of SDK build tasks as multi-threadable so MSBuild can schedule them concurrently when appropriate (per MSBuild-13059).
Changes:
- Add
[MSBuildMultiThreadableTask]to multiple tasks insrc/Tasks/sdk-tasksto indicate they are thread-safe for parallel execution. - No functional logic changes beyond task metadata/attributes.
Reviewed changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/Tasks/sdk-tasks/ZipFileCreateFromDirectory.cs | Mark task as MSBuild multi-threadable. |
| src/Tasks/sdk-tasks/UpdateRuntimeConfig.cs | Mark task as MSBuild multi-threadable. |
| src/Tasks/sdk-tasks/ReplaceFilesWithSymbolicLinks.cs | Mark task as MSBuild multi-threadable. |
| src/Tasks/sdk-tasks/ReplaceFileContents.cs | Mark task as MSBuild multi-threadable. |
| src/Tasks/sdk-tasks/RemoveAssetFromDepsPackages.cs | Mark task as MSBuild multi-threadable. |
| src/Tasks/sdk-tasks/ProcessRuntimeAnalyzerVersions.cs | Mark task as MSBuild multi-threadable. |
| src/Tasks/sdk-tasks/OverrideAndCreateBundledNETCoreAppPackageVersion.cs | Mark task as MSBuild multi-threadable. |
| src/Tasks/sdk-tasks/GetWorkloadSetFeatureBand.cs | Mark task as MSBuild multi-threadable. |
| src/Tasks/sdk-tasks/GetRuntimePackRids.cs | Mark task as MSBuild multi-threadable. |
| src/Tasks/sdk-tasks/GetLinuxNativeInstallerDependencyVersions.cs | Mark task as MSBuild multi-threadable. |
| src/Tasks/sdk-tasks/GetDependencyInfo.cs | Mark task as MSBuild multi-threadable. |
| src/Tasks/sdk-tasks/GenerateSdkRuntimeIdentifierChain.cs | Mark task as MSBuild multi-threadable. |
| src/Tasks/sdk-tasks/GenerateRuntimeAnalyzersSWR.cs | Mark task as MSBuild multi-threadable. |
| src/Tasks/sdk-tasks/GenerateMsiVersionFromFullVersion.cs | Mark task as MSBuild multi-threadable. |
| src/Tasks/sdk-tasks/GenerateMSBuildExtensionsSWR.cs | Mark task as MSBuild multi-threadable. |
| src/Tasks/sdk-tasks/GenerateDefaultRuntimeFrameworkVersion.cs | Mark task as MSBuild multi-threadable. |
| src/Tasks/sdk-tasks/ChangeEntryPointLibraryName.cs | Mark task as MSBuild multi-threadable. |
| src/Tasks/sdk-tasks/CalculateTemplateVersions.cs | Mark task as MSBuild multi-threadable. |
| src/Tasks/sdk-tasks/AddMetadataIsPE.cs | Mark task as MSBuild multi-threadable. |
This was referenced Jan 19, 2026
SimaTian
commented
Jan 20, 2026
SimaTian
commented
Jan 20, 2026
SimaTian
commented
Jan 20, 2026
SimaTian
commented
Jan 20, 2026
SimaTian
commented
Jan 20, 2026
SimaTian
commented
Jan 20, 2026
SimaTian
commented
Jan 20, 2026
SimaTian
commented
Jan 20, 2026
SimaTian
commented
Jan 20, 2026
SimaTian
commented
Jan 20, 2026
SimaTian
commented
Jan 20, 2026
SimaTian
commented
Jan 20, 2026
SimaTian
commented
Jan 20, 2026
SimaTian
commented
Jan 20, 2026
Member
Author
|
here the Opus analysis success rate was abysmal - like 10%? |
JanProvaznik
approved these changes
Jan 27, 2026
This was referenced Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Marking tasks as threadsafe. Issue MSBuild-13059
These should be safe enough to mark as they don't use any static state or file manipulation.