Unwind changes done during the TFM update#52512
Conversation
|
@marcpopMSFT I'm talking with @ericstj / @jozkee about that part of the analysislevel tests as part of solving #52487 - we're thinking that analysislevel needs two bumps:
so I'd expect this test to change a bit to help codify that. |
There was a problem hiding this comment.
Pull request overview
This pull request unwinds changes that were made during a Target Framework Moniker (TFM) update for .NET 11. The primary goal is to re-enable tests that were previously skipped and update minimum version requirements for Visual Studio and MSBuild.
Changes:
- Re-enables approximately 30 test methods across multiple test files that were previously skipped due to issue #51491
- Updates minimum Visual Studio version requirement from 17.16 to 19.0 for unsupported target framework error messages
- Updates minimum MSBuild version from 17.14.0 to 18.0.0
- Changes a test constant from
NextTargetFrameworkVersiontoCurrentTargetFramework
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| test/dotnet.Tests/CommandTests/Workload/Clean/GivenDotnetWorkloadClean.cs | Incorrect change from NextTargetFrameworkVersion to CurrentTargetFramework |
| test/dotnet-watch.Tests/HotReload/RuntimeProcessLauncherTests.cs | Re-enables 4 tests with empty parentheses syntax |
| test/dotnet-watch.Tests/HotReload/CompilationHandlerTests.cs | Re-enables 1 test with empty parentheses syntax |
| test/dotnet-watch.Tests/HotReload/ApplyDeltaTests.cs | Re-enables 19 tests, one with missing TestPlatforms parameter |
| test/dotnet-watch.Tests/CommandLine/ProgramTests.cs | Re-enables 1 test |
| test/dotnet-watch.Tests/Browser/BrowserTests.cs | Re-enables 1 test |
| test/Microsoft.NET.Sdk.BlazorWebAssembly.Tests/WasmPublishIntegrationTest.cs | Re-enables 3 tests |
| test/Microsoft.NET.Sdk.BlazorWebAssembly.Tests/WasmBuildIntegrationTest.cs | Re-enables 1 test |
| src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.SupportedTargetFrameworks.props | Updates minimum VS version for .NET 12 targeting |
| src/Layout/redist/minimumMSBuildVersion | Updates minimum MSBuild version to 18.0.0 |
test/dotnet-watch.Tests/HotReload/RuntimeProcessLauncherTests.cs
Outdated
Show resolved
Hide resolved
test/dotnet.Tests/CommandTests/Workload/Clean/GivenDotnetWorkloadClean.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…oadClean.cs Co-authored-by: Larry Ewing <lewing@microsoft.com>
|
@tmat looks like the remaining failure is a timeout in a watch test. Any ideas? I looked at multiple legs and it was the same test. Should I redisable that one for now? |
Mostly this reenables a bunch of tests without determining if they'll pass or not.
Also updates the minimum VS version as that should be done for 10.0.2xx as well.
I also looked at removing nexttargetframework but test It_defaults_preview_AnalysisLevel_to_the_next_tfm still uses it. Someone should review that.