Make it possible to opt out of creating a dylib from the R2R output.#52480
Make it possible to opt out of creating a dylib from the R2R output.#52480jkoritzinsky merged 4 commits intodotnet:mainfrom
Conversation
For the iOS SDK, we're going to create the dylib using our own logic, because our own logic supports executing remotely on a Mac.
There was a problem hiding this comment.
Pull request overview
This pull request introduces the ability to opt out of creating a dylib (shared library) from Ready-to-Run (R2R) output for iOS SDK scenarios. The change allows the iOS SDK to use its own logic for dylib creation, particularly to support executing remotely on a Mac.
Changes:
- Added a new MSBuild property
PublishReadyToRunCreateSharedLibraryto control dylib creation - Modified the
_LinkReadyToRunMachOtarget condition to respect this opt-out property
src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.CrossGen.targets
Show resolved
Hide resolved
src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.CrossGen.targets
Show resolved
Hide resolved
src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.CrossGen.targets
Show resolved
Hide resolved
jkoritzinsky
left a comment
There was a problem hiding this comment.
I think this looks good. The error experience will be a little funky if someone sets this property without using the iOS SDK, but I think that's fine.
elinor-fung
left a comment
There was a problem hiding this comment.
I guess setting the new property to false really only applies to macho container format right now, but I don't think it is worth adding anything to validate / error.
|
The failures don't look related to my changes, anything I can do to get this merged? |
For the iOS SDK, we're going to create the dylib using our own logic, because
our own logic supports executing remotely on a Mac.