Remove duplicate NuGet package properties from Version.Details.props#51793
Merged
jonathanpeppers merged 2 commits intodarc-main-25319f2a-bdb3-4d70-a139-7a9acdfbdccefrom Nov 18, 2025
Merged
Conversation
…s.props Co-authored-by: jonathanpeppers <840039+jonathanpeppers@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update source code from dotnet/dotnet
Remove duplicate NuGet package properties from Version.Details.props
Nov 18, 2025
MiYanni
approved these changes
Nov 18, 2025
Member
MiYanni
left a comment
There was a problem hiding this comment.
This looks correct to me. The state of the file seems to indicate that it was merged from 2 different branches with changes to these properties, where one branch updated and moved them and the other likely updated them in-place. Copilot seems to be deleting the older versions of the same duplicate properties, so I think this is correct.
91496aa
into
darc-main-25319f2a-bdb3-4d70-a139-7a9acdfbdcce
3 of 5 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Version.Details.props validation was failing due to duplicate property definitions introduced during dependency flow from multiple sources.
Changes
The affected properties:
MicrosoftBuildNuGetSdkResolverPackageVersionNuGetBuildTasks*PackageVersion(multiple variants)NuGetCommandLine*PackageVersionNuGetCommon*PackageVersionThis resolves the "Missing Properties" validation error where dependencies in Version.Details.xml had conflicting property definitions in Version.Details.props.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.