Skip to content

Fix template package version separator in test baselines and assertions#51782

Merged
marcpopMSFT merged 3 commits intodarc-main-25319f2a-bdb3-4d70-a139-7a9acdfbdccefrom
copilot/sub-pr-51402
Nov 17, 2025
Merged

Fix template package version separator in test baselines and assertions#51782
marcpopMSFT merged 3 commits intodarc-main-25319f2a-bdb3-4d70-a139-7a9acdfbdccefrom
copilot/sub-pr-51402

Conversation

Copy link
Contributor

Copilot AI commented Nov 17, 2025

The templating repository changed the version separator format from :: to @ for displaying template package identifiers (e.g., Microsoft.DotNet.Common.ProjectTemplates.5.0::5.0.0Microsoft.DotNet.Common.ProjectTemplates.5.0@5.0.0).

Changes

  • Updated 7 test verification baseline files in test/dotnet-new.IntegrationTests/Approvals/ to use @ separator instead of ::

    • Files: DotnetNewInstallTests.CannotInstallPackageAvailableFromBuiltIns.verified.txt, CannotInstallSameSourceTwice_NuGet.verified.txt, CanInstallSameSourceTwice_RemoteNuGet_WhenSourceIsSpecified.verified.txt, CanShowDeprecationMessage_WhenLegacyCommandIsUsed_common.verified.txt, DoNotShowDeprecationMessage_WhenNewCommandIsUsed.verified.txt, CanInstallPackageAvailableFromBuiltInsWithForce.verified.txt, CannotInstallMultiplePackageAvailableFromBuiltIns.verified.txt
  • Updated 3 test code files with assertion patterns to use @ separator instead of ::

    • DotnetNewInstallTests.cs: 14 pattern replacements
    • DotnetNewUninstallTests.cs: 3 pattern replacements
    • DotnetNewUpdateTests.cs: 1 pattern replacement

Example changes:

-Microsoft.DotNet.Common.ProjectTemplates.5.0::5.0.0 is already installed.
+Microsoft.DotNet.Common.ProjectTemplates.5.0@5.0.0 is already installed.
-.And.HaveStdOutMatching($"Success: Microsoft\\.DotNet\\.Web\\.ProjectTemplates\\.5\\.0::([\\d\\.a-z-])+ installed the following templates:")
+.And.HaveStdOutMatching($"Success: Microsoft\\.DotNet\\.Web\\.ProjectTemplates\\.5\\.0@([\\d\\.a-z-])+ installed the following templates:")

Total: 25 replacements across 10 files to align with the new templating format.


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: marcpopMSFT <12663534+marcpopMSFT@users.noreply.github.com>
Copilot AI changed the title [WIP] Update source code from dotnet/dotnet Fix template package version separator in test baselines Nov 17, 2025
Copilot AI requested a review from marcpopMSFT November 17, 2025 19:52
@marcpopMSFT
Copy link
Member

dotnet-new.IntegrationTests_net10.0_x64.xml
@copilot My list showed 26 tests that were failing because of this issue. Can you confirm with the above xml that there aren't any additional tests that need to be fixed that you didn't already fix?

Co-authored-by: marcpopMSFT <12663534+marcpopMSFT@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Nov 17, 2025

dotnet-new.IntegrationTests_net10.0_x64.xml
@copilot My list showed 26 tests that were failing becaus...

Confirmed. I've fixed all 25 instances:

  • 7 verified.txt baseline files (commit 3d785e8)
  • 18 test assertion patterns across 3 test files (commit f88dc2b):
    • DotnetNewInstallTests.cs: 14 patterns
    • DotnetNewUninstallTests.cs: 3 patterns
    • DotnetNewUpdateTests.cs: 1 pattern

All :: separators in template package identifiers have been replaced with @.

Copilot AI changed the title Fix template package version separator in test baselines Fix template package version separator in test baselines and assertions Nov 17, 2025
@marcpopMSFT marcpopMSFT marked this pull request as ready for review November 17, 2025 22:42
@marcpopMSFT marcpopMSFT requested a review from a team as a code owner November 17, 2025 22:42
@marcpopMSFT marcpopMSFT merged commit dc69651 into darc-main-25319f2a-bdb3-4d70-a139-7a9acdfbdcce Nov 17, 2025
3 of 5 checks passed
@marcpopMSFT marcpopMSFT deleted the copilot/sub-pr-51402 branch November 17, 2025 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants