Include FileBasedPrograms package project in the solution#51587
Merged
RikkiGibson merged 1 commit intodotnet:release/10.0.2xxfrom Nov 6, 2025
Merged
Include FileBasedPrograms package project in the solution#51587RikkiGibson merged 1 commit intodotnet:release/10.0.2xxfrom
RikkiGibson merged 1 commit intodotnet:release/10.0.2xxfrom
Conversation
This was referenced Nov 6, 2025
jjonescz
approved these changes
Nov 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #51581 and #51373.
PackageArtifacts for FileBasedPrograms were still not present in the official build after the IsShipping change: https://dev.azure.com/dnceng/internal/_build/results?buildId=2832403&view=artifacts&pathAsName=false&type=publishedArtifacts.
Kinda funny how far I managed to get without ever actually adding the new project to the solution. (It looks like the project was built in CI basically just due to being referenced by
dotnet.csproj.)This time I ran
build.cmd -packlocally and saw that the FileBasedPrograms nupkg with an up to date timestamp actually appears in my localartifacts/packagesfolder. That did not happen prior to this change. So I feel somewhat more confident that stuff really should get published this time.@jjonescz if you are able to sign off once you see this is green that would be great, I am hoping I can get up in the morning and actually start using the package.