Stable versioning for placeholder MSI#51496
Merged
NikolaMilosavljevic merged 1 commit intodotnet:release/10.0.1xxfrom Nov 1, 2025
Merged
Stable versioning for placeholder MSI#51496NikolaMilosavljevic merged 1 commit intodotnet:release/10.0.1xxfrom
NikolaMilosavljevic merged 1 commit intodotnet:release/10.0.1xxfrom
Conversation
Member
Author
|
@marcpopMSFT I think this can be merged as soon as it's approved, right? |
Member
|
Since this affects the product, it should probably be sent to tactics. Can you fill out the template and mark it servicing consider? For the template, I typically just copy from other PRs marked servicing-approved (it's ~5 sections). |
Member
|
and yes, I think we can merge once tactics approves as the new model for 10+ allows for earlier fixes per Matt |
marcpopMSFT
approved these changes
Oct 31, 2025
f29165f
into
dotnet:release/10.0.1xx
29 of 30 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the issue with .NET SDK version in ARP. Placeholder MSI is installed with VS and it holds the value that is displayed in ARP, in
ProductNameproperty.This PR changes how
Versionproperty is evaluated to ensure the prerelease suffix is not included.Tested in internal build
Similar fix was previously made for bundle package.