Merged
Conversation
PranavSenthilnathan
approved these changes
Oct 6, 2025
wtgodbe
approved these changes
Oct 6, 2025
merriemcgaw
reviewed
Oct 6, 2025
| <?if $(TargetArchitecture)~=x86?> | ||
| <SoftwareTag Regid="microsoft.com" InstallPath="[ProgramFilesFolder]dotnet" /> | ||
| <?else?> | ||
| <SoftwareTag Regid="microsoft.com" InstallPath="[ProgramFiles64Folder]dotnet]" /> |
Member
There was a problem hiding this comment.
do you need the extra ] after dotnet the end of the line here?
Member
Author
There was a problem hiding this comment.
Thanks for catching that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a regression from migrating to WiX v5. Using the new
ProgramFiles6432Foldervariable causes non-native installations to always write the SWID tag toCSIDL_PROGRAM_FILES. When installing the x86 SDK on 64-bit Windows, the tag ends up underProgram Filesinstead ofProgram Files (x86).Testing
Manual test