[dotnet-watch] Notify DCP of terminated session when process exits on its own#50992
Merged
marcpopMSFT merged 2 commits intodotnet:release/10.0.1xxfrom Sep 30, 2025
Merged
Conversation
Contributor
|
This PR is targeting |
Contributor
|
Thanks for your PR, @@tmat. |
3bca85d to
85bf7bf
Compare
85bf7bf to
1dd6d3b
Compare
1dd6d3b to
fc261e5
Compare
This was referenced Sep 25, 2025
5dc2950 to
4fa949d
Compare
6471a0c to
b942ea0
Compare
b942ea0 to
0dd4e52
Compare
Member
Author
|
@DustinCampbell ptal |
DustinCampbell
approved these changes
Sep 29, 2025
Member
DustinCampbell
left a comment
There was a problem hiding this comment.
I read through everything and didn't spot any cases where cancellation tokens and disposable objects didn't flow as they did before.
| @@ -384,19 +381,7 @@ await Task.WhenAll( | |||
| projectsToRestart.Select(async runningProject => | |||
| { | |||
| var newRunningProject = await runningProject.RestartOperation(shutdownCancellationToken); | |||
Member
There was a problem hiding this comment.
Does RestartOperation need an "Async" suffix?
|
|
||
| var message = new StringBuilder(); | ||
| message.AppendLine($"Expected output {(expectedPresent ? "not found" : "found")}:"); | ||
|
|
Member
|
approved via email, failure is a known issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previously we only notified DCP when dotnet-watch terminated the process.
Fixes cancellation handling in a few places to avoid reporting errors that are caused by expected process termination/shutdown and pass correct cancellation tokens.
Fixes process output redirection for Aspire child processes.
Fixes #50952
Fixes dotnet/aspire#9756
Customer Impact
Impacts Aspire customers.
Regression?
Risk
Justification: Only impacts dotnet-watch and Aspire CLI.
Verification
Packaging changes reviewed?