Update analyzer redirecting VS extension#50496
Merged
jjonescz merged 11 commits intodotnet:release/10.0.1xxfrom Sep 26, 2025
Merged
Update analyzer redirecting VS extension#50496jjonescz merged 11 commits intodotnet:release/10.0.1xxfrom
jjonescz merged 11 commits intodotnet:release/10.0.1xxfrom
Conversation
This reverts commit d91fcd6.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the analyzer redirecting VS extension to complete the implementation following up on a previous PR. Key changes include adding an opt-out environment variable, improving the VS extension configuration, and restructuring the analyzer layout.
- Added logging capabilities and opt-out environment variable (
DOTNET_ANALYZER_REDIRECTING) - Restructured analyzer deployment layout to remove version numbers from directories
- Updated VS extension to be a system component that doesn't appear in installed extensions list
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
test/Microsoft.Net.Sdk.AnalyzerRedirecting.Tests/SdkAnalyzerAssemblyRedirectorTests.cs |
Updated tests to use new metadata-based version tracking instead of version directories |
src/Tasks/sdk-tasks/sdk-tasks.InTree.targets |
Added new MSBuild task ProcessRuntimeAnalyzerVersions for version extraction |
src/Tasks/sdk-tasks/ProcessRuntimeAnalyzerVersions.cs |
New task to extract version numbers and create metadata JSON file |
src/Tasks/sdk-tasks/GenerateRuntimeAnalyzersSWR.cs |
Updated layout paths and added metadata.json file inclusion |
src/Microsoft.Net.Sdk.AnalyzerRedirecting/source.extension.vsixmanifest |
Updated to VS 19.0 compatibility and system component configuration |
src/Microsoft.Net.Sdk.AnalyzerRedirecting/SdkAnalyzerAssemblyRedirector.cs |
Added logging, opt-out mechanism, and updated to use metadata-based version lookup |
src/Microsoft.Net.Sdk.AnalyzerRedirecting/Microsoft.Net.Sdk.AnalyzerRedirecting.csproj |
Added System.Text.Json dependency for metadata processing |
src/Layout/VS.Redist.Common.Net.Core.SDK.RuntimeAnalyzers/VS.Redist.Common.Net.Core.SDK.RuntimeAnalyzers.proj |
Updated build process to use new version extraction and VS extension configuration |
documentation/general/analyzer-redirecting.md |
Updated documentation to reflect new metadata-based approach |
src/Microsoft.Net.Sdk.AnalyzerRedirecting/SdkAnalyzerAssemblyRedirector.cs
Show resolved
Hide resolved
Member
Author
|
@JoeRobich @RikkiGibson @333fred for reviews, thanks Btw, I think I can merge this into |
333fred
reviewed
Sep 24, 2025
This was referenced Sep 25, 2025
333fred
approved these changes
Sep 25, 2025
MiYanni
approved these changes
Sep 25, 2025
JoeRobich
approved these changes
Sep 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up on #42861.