[release/9.0.3xx][StaticWebAssets] Explicitly use invariant culture during parsing#49056
Merged
lewing merged 1 commit intorelease/9.0.3xxfrom Jun 19, 2025
Merged
[release/9.0.3xx][StaticWebAssets] Explicitly use invariant culture during parsing#49056lewing merged 1 commit intorelease/9.0.3xxfrom
lewing merged 1 commit intorelease/9.0.3xxfrom
Conversation
6140945 to
19caf73
Compare
19caf73 to
fe21e8d
Compare
MackinnonBuck
approved these changes
May 23, 2025
Member
|
@javiercn @MackinnonBuck were you going to get tactics approval for this? Branch is only open a few days. |
Member
Author
|
@marcpopMSFT Yes. |
fe21e8d to
42be706
Compare
lewing
approved these changes
Jun 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explicitly use invariant culture during parsing
Parsing fails on some localized installations of the SDK.
Description
We serialize the information using
InvariantCultureand a specific format but then we try to deserialize that data later using the current culture, which results in the field being reported as missing and the build eventually failing.Customer Impact
Builds will fail for customers where the current culture is not compatible with the invariant culture. The cases where we have seen this reported have been Spanish based culture (based on the language of the error message).
Regression?
Risk
The fix is to use
InvariantCulturewhen processing the field. In addition to that, we also included a fallback to re-compute the information in case it fails for some reason.Verification