Add HttpResults to the ImplicitUsings of ASP.NET Core projects so TypedResults/Results<T1,T2> don't need an explicit using#47231
Closed
sander1095 wants to merge 2 commits intodotnet:mainfrom
Conversation
…xplicitly need to be added to Program.cs of Minimal API projects, reducing clutter
4 tasks
Author
|
Closing because the decision has been made in the mentioned PR to stick with explicit usings |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This issue is related to dotnet/aspnetcore#60337, in which we enrich the
webapiaottemplate with OpenAPI by default, which can be disabled with--no-openapi. In order to write endpoints with correct OpenAPI metadata,TypedResultsandResults<T1,T2>are used, which are part of theMicrosoft.AspNetCore.Http.HttpResultsnamespace.The build of the mentioned PR failed because the usings for the mentioned types were not available. While researching this, I found out that this is because
ImplicitUsingsfor ASP.NET Core projects doesn't add these types.There are 2 options:
HttpResultsnamespace with an explicit usingTypedResultsare used.Microsoft.AspNetCore.Http.HttpResultsto the list of usings that should be globally added whenImplicitUsingsis enabled, which is what this PR does. This prevents a bit of "usingpollution", and is therefore (in my opinion) the preferred approach