[release/9.0.1xx] Check shipping packages for poison#47224
Merged
NikolaMilosavljevic merged 3 commits intorelease/9.0.1xxfrom Mar 3, 2025
Merged
[release/9.0.1xx] Check shipping packages for poison#47224NikolaMilosavljevic merged 3 commits intorelease/9.0.1xxfrom
NikolaMilosavljevic merged 3 commits intorelease/9.0.1xxfrom
Conversation
ViktorHofer
reviewed
Mar 3, 2025
Comment on lines
+117
to
+118
| <AssetToCheck Include="$(ArtifactsAssetsDir)*$(ArchiveExtension)" /> | ||
| <AssetToCheck Remove="$(ArtifactsAssetsDir)$(SourceBuiltArtifactsTarballName)*" /> |
Member
There was a problem hiding this comment.
nit: Instead of the additional Remove operation, I would add this as an Exclude to L117.
Member
There was a problem hiding this comment.
Thanks. I'd like to minimize the changes in this backport, especially as this was already the model before my PR.
Member
There was a problem hiding this comment.
Sure. Feel free to consider this for the PR targeting main.
NikolaMilosavljevic
approved these changes
Mar 3, 2025
ViktorHofer
reviewed
Mar 3, 2025
| <AssetToCheck Remove="$(ArtifactsAssetsDir)$(SourceBuiltArtifactsTarballName)*" /> | ||
| <!-- Include shipping nuget packages. --> | ||
| <PoisonFileToCheck Include="$(ArtifactsShippingPackagesDir)*.nupkg" /> | ||
| <ShippingPackageToCheck Include="$(ArtifactsShippingPackagesDir)**/*.nupkg" /> |
Member
There was a problem hiding this comment.
super tiny nit: inconsistent use path separator char. L122 uses \ which I would go with.
Member
There was a problem hiding this comment.
This whole targets file is Linux specific, so / isn't out of place, i.e.
mthalman
approved these changes
Mar 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #47176 to release/9.0.1xx
/cc @NikolaMilosavljevic