Skip to content

[main] Update dependencies from dotnet/msbuild#46356

Merged
dotnet-maestro[bot] merged 8 commits intomainfrom
darc-main-3127c183-31da-46ff-ba8d-ee6901b70207
Feb 3, 2025
Merged

[main] Update dependencies from dotnet/msbuild#46356
dotnet-maestro[bot] merged 8 commits intomainfrom
darc-main-3127c183-31da-46ff-ba8d-ee6901b70207

Conversation

@dotnet-maestro
Copy link
Copy Markdown
Contributor

@dotnet-maestro dotnet-maestro bot commented Jan 28, 2025 •
edited
Loading

This pull request updates the following dependencies

From https://github.com/dotnet/msbuild

  • Subscription: 51256791-e30b-4b96-f2b9-08daf1d75f3f
  • Build: 20250131.2
  • Date Produced: January 31, 2025 12:15:52 PM UTC
  • Commit: 7e539c169a657040eeb768e8115c44f1780e59df
  • Branch: refs/heads/main

@dotnet-maestro
Update dependencies from https://github.com/dotnet/msbuild build 2025…
6f1db97 
…0127.6

Microsoft.SourceBuild.Intermediate.msbuild , Microsoft.Build , Microsoft.Build.Localization
 From Version 17.14.0-preview-25073-02 -> To Version 17.14.0-preview-25077-06
@ghost ghost added Area-CodeFlow untriaged Request triage from a team member labels Jan 28, 2025
This was referenced Jan 28, 2025
Open
Open
Closed
@ViktorHofer ViktorHofer mentioned this pull request Jan 28, 2025
Merged
@dotnet-maestro
Update dependencies from https://github.com/dotnet/msbuild build 2025…
38fe57c 
…0128.4

Microsoft.SourceBuild.Intermediate.msbuild , Microsoft.Build , Microsoft.Build.Localization
 From Version 17.14.0-preview-25073-02 -> To Version 17.14.0-preview-25078-04
This was referenced Jan 30, 2025
Closed
Open
Closed
@dotnet-maestro
Update dependencies from https://github.com/dotnet/msbuild build 2025…
cc799ba 
…0129.1

Microsoft.SourceBuild.Intermediate.msbuild , Microsoft.Build , Microsoft.Build.Localization
 From Version 17.14.0-preview-25073-02 -> To Version 17.14.0-preview-25079-01
@dotnet-maestro
Update dependencies from https://github.com/dotnet/msbuild build 2025…
c5f856a 
…0130.1

Microsoft.SourceBuild.Intermediate.msbuild , Microsoft.Build , Microsoft.Build.Localization
 From Version 17.14.0-preview-25073-02 -> To Version 17.14.0-preview-25080-01
@MiYanni
Copy link
Copy Markdown
Member

MiYanni commented Jan 31, 2025

@rainersigwald Looks like the test GivenThatWeWantMSBuildToRespectCustomCulture.SupportRespectAlreadyAssignedItemCulture_IsNotSupported_BuildShouldWarn is failing for both the .NET 6 and .NET 7 values. PTAL

@rainersigwald
Copy link
Copy Markdown
Member

rainersigwald commented Jan 31, 2025

@MiYanni please tag @dotnet/kitten for this sort of investigation. For this one I suspect @JanKrivanek will want to take a look.

@MiYanni
Copy link
Copy Markdown
Member

MiYanni commented Jan 31, 2025

@dotnet/kitten Could someone add the kitten alias to our CODEOWNERS file? That let's us know who to ping for codeflow issues.

@MiYanni MiYanni mentioned this pull request Jan 31, 2025
Merged
@dotnet-maestro
Update dependencies from https://github.com/dotnet/msbuild build 2025…
6d31234 
…0131.2

Microsoft.SourceBuild.Intermediate.msbuild , Microsoft.Build , Microsoft.Build.Localization
 From Version 17.14.0-preview-25073-02 -> To Version 17.14.0-preview-25081-02
@build-analysis build-analysis bot mentioned this pull request Feb 1, 2025
Closed
3 tasks
@JanKrivanek
Copy link
Copy Markdown
Member

JanKrivanek commented Feb 3, 2025

@rainersigwald Looks like the test GivenThatWeWantMSBuildToRespectCustomCulture.SupportRespectAlreadyAssignedItemCulture_IsNotSupported_BuildShouldWarn is failing for both the .NET 6 and .NET 7 values. PTAL

Yeah the behavior was made opt-in (in dotnet/msbuild#11320) - so reflecting that in unit tests here.
Once proven here - same fix will need to be applied in #46358 as well

@dotnet-maestro dotnet-maestro bot merged commit ab3ffaa into main Feb 3, 2025
@dotnet-maestro dotnet-maestro bot deleted the darc-main-3127c183-31da-46ff-ba8d-ee6901b70207 branch February 3, 2025 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joeloff joeloff joeloff approved these changes

Assignees

No one assigned

Labels

Area-CodeFlow untriaged Request triage from a team member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@MiYanni @rainersigwald @JanKrivanek @joeloff @JanProvaznik