Skip to content

Remove alpine n-1 leg#46065

Merged
ellahathaway merged 5 commits intodotnet:mainfrom
ellahathaway:remove-alpineprevious
Jan 17, 2025
Merged

Remove alpine n-1 leg#46065
ellahathaway merged 5 commits intodotnet:mainfrom
ellahathaway:remove-alpineprevious

Conversation

@ellahathaway
Copy link
Copy Markdown
Member

@ellahathaway ellahathaway commented Jan 16, 2025

Related to dotnet/source-build#4819

This PR removes the alpine n-1 leg.

This PR also moves the poison check from the alpine offline previous sdk leg to the centos offline previous sdk leg.

@ellahathaway ellahathaway requested review from a team as code owners January 16, 2025 22:11
@ghost ghost added Area-Infrastructure untriaged Request triage from a team member labels Jan 16, 2025
mthalman
mthalman reviewed Jan 16, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@mthalman mthalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doc should also be updated, but that's a separate repo:

https://github.com/dotnet/source-build/blob/b56f5c5da95ef5e697c73efc1efb668e4d63db69/Documentation/ci-platform-coverage-guidelines.md?plain=1#L44

@ellahathaway
Copy link
Copy Markdown
Member Author

ellahathaway commented Jan 16, 2025

Thoughts on running the centos offline previous sdk leg in the lite pipeline as well? Alpine offline previous sdk leg used to run in the lite pipeline.

@ellahathaway ellahathaway requested a review from mthalman January 16, 2025 22:49
MichaelSimons
MichaelSimons reviewed Jan 16, 2025
View reviewed changes
@MichaelSimons
Copy link
Copy Markdown
Member

MichaelSimons commented Jan 16, 2025

Thoughts on running the centos offline previous sdk leg in the lite pipeline as well? Alpine offline previous sdk leg used to run in the lite pipeline.

Yes, I think it is important to maintain running a leg with the previous sdk in lite.

This was referenced Jan 17, 2025
Open
Closed
Open
@MichaelSimons
Copy link
Copy Markdown
Member

MichaelSimons commented Jan 17, 2025

Thoughts on running the centos offline previous sdk leg in the lite pipeline as well? Alpine offline previous sdk leg used to run in the lite pipeline.

Yes, I think it is important to maintain running a leg with the previous sdk in lite.

@ellahathaway, Are you going to make this change in this PR? Asking as I saw a review request was made.

@ellahathaway ellahathaway force-pushed the remove-alpineprevious branch from 59f22a4 to 7ad93af Compare January 17, 2025 17:12
@ellahathaway
Copy link
Copy Markdown
Member Author

ellahathaway commented Jan 17, 2025

Thoughts on running the centos offline previous sdk leg in the lite pipeline as well? Alpine offline previous sdk leg used to run in the lite pipeline.

Yes, I think it is important to maintain running a leg with the previous sdk in lite.

@ellahathaway, Are you going to make this change in this PR? Asking as I saw a review request was made.

Ah yes. I accidentally moved the alpine msft leg instead of the centos previous sdk leg. I fixed this in 7ad93af

@ellahathaway ellahathaway enabled auto-merge (squash) January 17, 2025 19:07
@ellahathaway ellahathaway mentioned this pull request Jan 17, 2025
Merged
@ellahathaway ellahathaway merged commit b119ba9 into dotnet:main Jan 17, 2025
This was referenced Jan 17, 2025
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MichaelSimons MichaelSimons MichaelSimons approved these changes

@mthalman mthalman mthalman approved these changes

Assignees

No one assigned

Labels

Area-Infrastructure untriaged Request triage from a team member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ellahathaway @MichaelSimons @mthalman