Skip to content

Update MSB3825 warning presence#45861

Merged
JanKrivanek merged 2 commits intomainfrom
JanKrivanek-patch-1
Jan 15, 2025
Merged

Update MSB3825 warning presence#45861
JanKrivanek merged 2 commits intomainfrom
JanKrivanek-patch-1

Conversation

@JanKrivanek
Copy link
Copy Markdown
Member

Contributes to dotnet/msbuild#11185

Context

dotnet/msbuild#11185 (comment)

It was decided that MSB3825 should not be applicalbe to NET9+ - as BinaryFormatter is being used only in a very limited number of subcases, where it needs to be explicitly opted in via System.Resources.Extensions.UseBinaryFormatter switch.

@ghost ghost added Area-Infrastructure untriaged Request triage from a team member labels Jan 10, 2025
@ViktorHofer
Copy link
Copy Markdown
Member

Updating with latest main as we had a build break that just got fixed with 6b3a36d

@JanKrivanek
Copy link
Copy Markdown
Member Author

@dotnet/domestic-cat is the frequency of OSX leg build failures expected? I'm reruning for 4th time :-O

@Forgind
Copy link
Copy Markdown
Contributor

Forgind commented Jan 15, 2025

@dotnet/domestic-cat is the frequency of OSX leg build failures expected? I'm reruning for 4th time :-O

Unfortunately the macOS arm64 leg specifically is timing out, and we haven't figured out why yet, so not your fault in this case.

We made it optional so we can merge past it with 1 approving review.

@JanKrivanek JanKrivanek merged commit db55513 into main Jan 15, 2025
@JanKrivanek JanKrivanek deleted the JanKrivanek-patch-1 branch January 15, 2025 19:33
@Forgind
Copy link
Copy Markdown
Contributor

Forgind commented Jan 15, 2025

@JanKrivanek, this looks good to me. Do you want it backported? 9.0.3xx is open for changes. I think this would be low-risk enough that you could argue for it for 9.0.1xx or 9.0.2xx

@baronfel
Copy link
Copy Markdown
Member

Looks like we would want to take it for all 9.x SDKs if possible, based on the recommendation from the binaryformatter working group in the linked issue.

@Forgind
Copy link
Copy Markdown
Contributor

Forgind commented Jan 15, 2025

/backport to release/9.0.1xx

@github-actions
Copy link
Copy Markdown
Contributor

Started backporting to release/9.0.1xx: https://github.com/dotnet/sdk/actions/runs/12796505954

@JanKrivanek
Copy link
Copy Markdown
Member Author

/backport to release/9.0.2xx

@github-actions
Copy link
Copy Markdown
Contributor

Started backporting to release/9.0.2xx: https://github.com/dotnet/sdk/actions/runs/12803666854

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-Infrastructure untriaged Request triage from a team member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants