Change Aspire RunSessionRequest definition #45515
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karolz-ms
approved these changes
Dec 17, 2024
tmat
approved these changes
Dec 17, 2024
This was referenced Dec 17, 2024
Closed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses dotnet/aspire#6120
Whether or not
argsis null is an important piece of information to the IDE when the json gets deserialized. A value of null would indicate that a user-specified set of command line arguments can be used to launch the project. A non-null value (empty or not) would indicate that the user-specified set of command line arguments should be replaced with those in the array.The current model has a default value of
Array.Empty<string>()which means the IDE will always receive an array of strings regardless of whether the orchestrator passed null.This issue has been present for a while but was hidden because VS was not properly overriding user-specified command line arguments until 17.12.