Skip to content

Extend build server shutdown tracing#45393

Merged
marcpopMSFT merged 1 commit into
dotnet:mainfrom
jjonescz:shutdown-tracing
Dec 10, 2024
Merged

Extend build server shutdown tracing#45393
marcpopMSFT merged 1 commit into
dotnet:mainfrom
jjonescz:shutdown-tracing

Conversation

@jjonescz

@jjonescz jjonescz commented Dec 10, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

The output might look something like this:

❯ & "D:\sdk-3\.dotnet\dotnet.exe" exec D:\sdk-3\artifacts\bin\dotnet\Debug\net10.0\dotnet.dll build-server shutdown --vbcscompiler
Telemetry is: Disabled
Shutting down VB/C# compiler server...
Running D:\sdk-3\.dotnet\dotnet.exe exec D:\sdk-3\artifacts\bin\dotnet\Debug\net10.0\Roslyn\bincore\VBCSCompiler.dll -shutdown
> D:\sdk-3\.dotnet\dotnet.exe exec D:\sdk-3\artifacts\bin\dotnet\Debug\net10.0\Roslyn\bincore\VBCSCompiler.dll -shutdown
Process ID: 43340
< D:\sdk-3\.dotnet\dotnet.exe exec D:\sdk-3\artifacts\bin\dotnet\Debug\net10.0\Roslyn\bincore\VBCSCompiler.dll -shutdown exited with -2147450751 in 21 ms.
Shutting down 'microsoft.net.sdk.compilers.toolset' compilers.
Enumerating 'C:\.tools\.nuget\packages\microsoft.net.sdk.compilers.toolset'.
Found 'C:\.tools\.nuget\packages\microsoft.net.sdk.compilers.toolset\9.0.100-preview.7.24365.12\VBCSCompiler.exe'.
Running C:\.tools\.nuget\packages\microsoft.net.sdk.compilers.toolset\9.0.100-preview.7.24365.12\VBCSCompiler.exe -shutdown
> C:\.tools\.nuget\packages\microsoft.net.sdk.compilers.toolset\9.0.100-preview.7.24365.12\VBCSCompiler.exe -shutdown
Process ID: 22744
< C:\.tools\.nuget\packages\microsoft.net.sdk.compilers.toolset\9.0.100-preview.7.24365.12\VBCSCompiler.exe -shutdown exited with 0 in 112 ms.
Found 'C:\.tools\.nuget\packages\microsoft.net.sdk.compilers.toolset\9.0.101\VBCSCompiler.exe'.
Running C:\.tools\.nuget\packages\microsoft.net.sdk.compilers.toolset\9.0.101\VBCSCompiler.exe -shutdown
> C:\.tools\.nuget\packages\microsoft.net.sdk.compilers.toolset\9.0.101\VBCSCompiler.exe -shutdown
Process ID: 23660
< C:\.tools\.nuget\packages\microsoft.net.sdk.compilers.toolset\9.0.101\VBCSCompiler.exe -shutdown exited with 0 in 113 ms.

@ghost ghost added Area-CLI untriaged Request triage from a team member labels Dec 10, 2024
@jjonescz jjonescz marked this pull request as ready for review December 10, 2024 14:16
@build-analysis build-analysis Bot mentioned this pull request Dec 10, 2024
Open
ellahathaway
ellahathaway approved these changes Dec 10, 2024
View reviewed changes

@ellahathaway ellahathaway left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ellahathaway

ellahathaway commented Dec 10, 2024

Copy link
Copy Markdown
Member

Related to dotnet/source-build#4796

@ellahathaway ellahathaway mentioned this pull request Dec 10, 2024
Closed
@baronfel

baronfel commented Dec 10, 2024

Copy link
Copy Markdown
Member

The arm64 failures on macOS have been pretty persistent - @marcpopMSFT mind merging this on red to get better diagnosis?

@marcpopMSFT marcpopMSFT merged commit e423f31 into dotnet:main Dec 10, 2024
@ViktorHofer

ViktorHofer commented Dec 10, 2024

Copy link
Copy Markdown
Member

This broke the build :( Raced with b09e142

src/Cli/Microsoft.DotNet.Cli.Utils/Command.cs(44,28): error CS8600: (NETCORE_ENGINEERING_TELEMETRY=Build) Converting null literal or possible null value to non-nullable type.

@Winniexu01 Winniexu01 mentioned this pull request Dec 11, 2024
Closed
@v-wuzhai

v-wuzhai commented Dec 11, 2024

Copy link
Copy Markdown
Contributor

@jaredpar I tried to resolve the build failure, but it seems there are still other issues. Could you take a look at #45411?

@Winniexu01 Winniexu01 mentioned this pull request Dec 11, 2024
Closed
@jjonescz jjonescz deleted the shutdown-tracing branch December 11, 2024 10:17
@jjonescz jjonescz mentioned this pull request May 5, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jaredpar jaredpar jaredpar approved these changes

@baronfel baronfel baronfel approved these changes

@ellahathaway ellahathaway ellahathaway approved these changes

Assignees

No one assigned

Labels

Area-CLI untriaged Request triage from a team member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@jjonescz @ellahathaway @baronfel @ViktorHofer @v-wuzhai @jaredpar @marcpopMSFT