Skip to content

Continue printing out redirected process output after we detect browser launch URL.#44290

Merged
tmat merged 2 commits intodotnet:release/9.0.1xxfrom
tmat:Output
Oct 22, 2024
Merged

Continue printing out redirected process output after we detect browser launch URL.#44290
tmat merged 2 commits intodotnet:release/9.0.1xxfrom
tmat:Output

Conversation

@tmat
Copy link
Copy Markdown
Member

@tmat tmat commented Oct 17, 2024 •
edited
Loading

The logic that scans for browser launch URL in the process output stopped forwarding the output after the match has been found. This removes information logged by the web app after that point.

Fixes regression from .NET 8.0.

@tmat tmat requested a review from a team as a code owner October 17, 2024 23:49
@ghost ghost added Area-AspNetCore RazorSDK, BlazorWebAssemblySDK, StaticWebAssetsSDK untriaged Request triage from a team member labels Oct 17, 2024
@dotnet-policy-service
Copy link
Copy Markdown
Contributor

dotnet-policy-service bot commented Oct 17, 2024

Thanks for your PR, @tmat.
To learn about the PR process and branching schedule of this repo, please take a look at the SDK PR Guide.

@tmat
Copy link
Copy Markdown
Member Author

tmat commented Oct 17, 2024

@davidfowl @eerhardt

davidfowl
davidfowl reviewed Oct 18, 2024
View reviewed changes
@tmat tmat enabled auto-merge October 18, 2024 18:38
@build-analysis build-analysis bot mentioned this pull request Oct 18, 2024
Open
@marcpopMSFT
Copy link
Copy Markdown
Member

marcpopMSFT commented Oct 18, 2024

@tmat is this expected for GA and how close is it? I'm checking in on all remaining active 9.0.1xx PRs

@davidfowl
Copy link
Copy Markdown
Member

davidfowl commented Oct 19, 2024

Yes this is a regression

This was referenced Oct 19, 2024
Closed
Closed
@davidfowl davidfowl linked an issue Oct 19, 2024 that may be closed by this pull request
Dotnet watch pops browser and asks for auth token, but token is never printed to the console #44259
Closed
@tmat
Copy link
Copy Markdown
Member Author

tmat commented Oct 19, 2024

@marcpopMSFT Yes, for GA. Some dotnet new integration tests are intermittently failing in the CI. Restarting and hoping to merge today.

@tmat
Copy link
Copy Markdown
Member Author

tmat commented Oct 19, 2024

@marcpopMSFT Source build is failing with

Microsoft.DotNet.SourceBuild.SmokeTests.SourceBuiltArtifactsTests.VerifyVersionFile

Assert.Equal() Failure: Strings differ
                  ↓ (pos 7)
Expected: "9.0.100-rtm.24518.1"
Actual:   "9.0.100"

Unrelated to this PR.

@tmat tmat merged commit a8e91e9 into dotnet:release/9.0.1xx Oct 22, 2024
@tmat tmat deleted the Output branch October 22, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidfowl davidfowl davidfowl approved these changes

+1 more reviewer

@am11 am11 am11 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Area-AspNetCore RazorSDK, BlazorWebAssemblySDK, StaticWebAssetsSDK untriaged Request triage from a team member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Dotnet watch pops browser and asks for auth token, but token is never printed to the console

4 participants

@tmat @marcpopMSFT @davidfowl @am11