[release/9.0.1xx] BinSkim: Enable CFG#43695
Merged
joeloff merged 1 commit intodotnet:release/9.0.1xxfrom Sep 27, 2024
Merged
Conversation
Member
|
Silly question maybe, but on the .NET Framework leg do we have access to |
Member
Author
Depends if on the agent we're running inside a developer prompt - that usually sets those up because dumpbin comes from the Win SDK on the machine. But, if we were to regress this, 1ESPT/BinSkim will flag us again. |
Member
Author
|
Approved over email |
MiYanni
approved these changes
Sep 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
.NET SDK contains a native binary (finalizer.exe) that's used to clean up optional workloads when the SDK is uninstalled. The binary was flagged by BinSkim because control flow guard was not enabled.
Risk
Low
Testing
Built locally and verified that the necessary sections and tables are present as described here
Also tested the installer to ensure there aren't any regressions when running this when the SDK is being removed.