Allow reading of OCI Image Indexes to determine RID-specific base image for multi-architecture images#43631
Merged
baronfel merged 2 commits intodotnet:mainfrom Oct 4, 2024
Merged
Conversation
…architecture manifests
surayya-MS
reviewed
Oct 3, 2024
…logic for selecting the best manifest from a set of manifests
baronfel
commented
Oct 3, 2024
src/Containers/Microsoft.NET.Build.Containers/Registry/HttpExtensions.cs
Show resolved
Hide resolved
baronfel
commented
Oct 3, 2024
surayya-MS
approved these changes
Oct 4, 2024
Member
Author
|
/backport to release/9.0.1xx |
Member
Author
|
/backport to release/8.0.4xx |
Contributor
|
Started backporting to release/9.0.1xx: https://github.com/dotnet/sdk/actions/runs/11185853021 |
Contributor
|
Started backporting to release/8.0.4xx: https://github.com/dotnet/sdk/actions/runs/11185854727 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a small extension to allow for reading OCI Image Indexes the same as we do Docker Manifest Lists. It's hard to find images like this in the wild though, at least ones that can run .NET applications. This unblocks at least part of dotnet/sdk-container-builds#199 and fixes dotnet/sdk-container-builds#597.