Add missing SDK dependency to global.json #38426
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ViktorHofer
reviewed
Jan 31, 2024
| "Microsoft.DotNet.Arcade.Sdk": "9.0.0-beta.24080.3", | ||
| "Microsoft.DotNet.Helix.Sdk": "9.0.0-beta.24080.3" | ||
| "Microsoft.DotNet.Helix.Sdk": "9.0.0-beta.24080.3", | ||
| "Microsoft.Build.NoTargets": "3.7.0" |
Member
There was a problem hiding this comment.
Where is the NoTargets msbuild sdk used in this repo? How did this work without this entry before?
Member
Author
There was a problem hiding this comment.
Member
There was a problem hiding this comment.
Got it. Shouldn't this PR also remove that explicit version there?
Member
Author
There was a problem hiding this comment.
Good call - I was thinking of that as well - will do.
Member
Author
There was a problem hiding this comment.
Pushed the update to this PR with a fix for this.
Member
There was a problem hiding this comment.
Thanks. Please do the same in the other PRs as well.
Member
Author
There was a problem hiding this comment.
Sure - will update razor PR soon: dotnet/razor#9886
b8a9939 to
26b3421
Compare
mmitche
approved these changes
Jan 31, 2024
ViktorHofer
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to: dotnet/source-build#3170
Backport of changes in dotnet/installer#18478
Description
Each .NET repo needs to specify all used SDKs in
global.jsonfile. This change adds the missing SDK.