Compute SdkAnalysisLevel Property at the beginning of the SDK Targets#37778
Closed
baronfel wants to merge 1 commit intodotnet:mainfrom
Closed
Compute SdkAnalysisLevel Property at the beginning of the SDK Targets#37778baronfel wants to merge 1 commit intodotnet:mainfrom
baronfel wants to merge 1 commit intodotnet:mainfrom
Conversation
Member
|
The SDK folder contains both a .toolsetversion: .version |
Member
Author
|
Looking at the files in the 8.0.1xx SDKs I have installed, I see the following: The second line is the closest thing to what we want here, but we'd still have to do math on it in the same way this PR does to actually get the feature band for this SDK. Should we emit a file with the 'feature band' somewhere? |
Member
|
Should we store it in the bundled versions props file maybe, precompute at build time in the installer repo instead? |
Member
Author
|
Closing this in favor of dotnet/installer#18687 and a soon-to-be-opened SDK PR to read that value from the props. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a companion PR to dotnet/designs#308 to help bring clarity to the design doc.
It defines the SdkAnalysisLevel at the .NET Sdk.targets, basing it off of the
major.minor.featurebandof the current SDK when no user-defined value is present.Future work should add validation of this value during the beginning of execution to prevent invalid values from permeating through the system.