[main] Update dependencies from dotnet/arcade by dotnet-maestro[bot] · Pull Request #29800 · dotnet/sdk

dotnet-maestro · 2023-01-06T13:29:40Z

This pull request updates the following dependencies

Coherency Updates

The following updates ensure that dependencies with a CoherentParentDependency
attribute were produced in a build used as input to the parent dependency's build.
See Dependency Description Format

Coherency Updates:
- Microsoft.DotNet.XliffTasks: from 1.0.0-beta.23053.1 to 1.0.0-beta.23066.1 (parent: Microsoft.DotNet.Arcade.Sdk)

From https://github.com/dotnet/arcade

Subscription: 3d9043af-0e17-4eb5-f3e3-08d8e97c775d
Build: 20230117.5
Date Produced: January 18, 2023 1:57:58 AM UTC
Commit: 3600aa80a01e90f38a7b86b9d7c1264e091aa5a8
Branch: refs/heads/main

Updates:
- Microsoft.DotNet.Arcade.Sdk: from 8.0.0-beta.23054.2 to 8.0.0-beta.23067.5
- Microsoft.DotNet.Helix.Sdk: from 8.0.0-beta.23054.2 to 8.0.0-beta.23067.5
- Microsoft.DotNet.SignTool: from 8.0.0-beta.23054.2 to 8.0.0-beta.23067.5
- Microsoft.DotNet.XUnitExtensions: from 8.0.0-beta.23054.2 to 8.0.0-beta.23067.5
- Microsoft.DotNet.XliffTasks: from 1.0.0-beta.23053.1 to 1.0.0-beta.23066.1

…105.2 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.XUnitExtensions From Version 8.0.0-beta.23054.2 -> To Version 8.0.0-beta.23055.2 Dependency coherency updates Microsoft.DotNet.XliffTasks From Version 1.0.0-beta.23053.1 -> To Version 1.0.0-beta.23054.1 (parent: Microsoft.DotNet.Arcade.Sdk

…105.3 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.XUnitExtensions From Version 8.0.0-beta.23054.2 -> To Version 8.0.0-beta.23055.3 Dependency coherency updates Microsoft.DotNet.XliffTasks From Version 1.0.0-beta.23053.1 -> To Version 1.0.0-beta.23054.1 (parent: Microsoft.DotNet.Arcade.Sdk

…106.4 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.XUnitExtensions From Version 8.0.0-beta.23054.2 -> To Version 8.0.0-beta.23056.4 Dependency coherency updates Microsoft.DotNet.XliffTasks From Version 1.0.0-beta.23053.1 -> To Version 1.0.0-beta.23056.1 (parent: Microsoft.DotNet.Arcade.Sdk

…108.1 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.XUnitExtensions From Version 8.0.0-beta.23054.2 -> To Version 8.0.0-beta.23058.1 Dependency coherency updates Microsoft.DotNet.XliffTasks From Version 1.0.0-beta.23053.1 -> To Version 1.0.0-beta.23056.1 (parent: Microsoft.DotNet.Arcade.Sdk

nagilson · 2023-01-09T19:12:19Z

Template engine team has already been notified of this issue in another thread

…109.1 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.XUnitExtensions From Version 8.0.0-beta.23054.2 -> To Version 8.0.0-beta.23059.1 Dependency coherency updates Microsoft.DotNet.XliffTasks From Version 1.0.0-beta.23053.1 -> To Version 1.0.0-beta.23056.1 (parent: Microsoft.DotNet.Arcade.Sdk

nagilson · 2023-01-10T17:22:27Z

/azp run

azure-pipelines · 2023-01-10T17:22:38Z

Azure Pipelines successfully started running 1 pipeline(s).

…111.1 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.XUnitExtensions From Version 8.0.0-beta.23054.2 -> To Version 8.0.0-beta.23061.1 Dependency coherency updates Microsoft.DotNet.XliffTasks From Version 1.0.0-beta.23053.1 -> To Version 1.0.0-beta.23060.3 (parent: Microsoft.DotNet.Arcade.Sdk

nagilson · 2023-01-12T17:40:14Z

These issues appear to be unrelated to template engine now:

ci\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.FrameworkReferenceResolution.targets(90,5): error MSB4018:    at Microsoft.NET.Build.Tasks.ProcessFrameworkReferences.ExecuteCore() in //src/Tasks/Microsoft.NET.Build.Tasks/ProcessFrameworkReferences.cs:line 383

A lot of BlazorWasm, ILLink tests are failing.

@dotnet/aspnet-blazor-eng

ViktorHofer · 2023-01-13T09:25:46Z

cc @marcpopMSFT @MichaelSimons I think we want to get this in asap as Preview 1 code-complete is soon approaching.

…112.3 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.XUnitExtensions From Version 8.0.0-beta.23054.2 -> To Version 8.0.0-beta.23062.3 Dependency coherency updates Microsoft.DotNet.XliffTasks From Version 1.0.0-beta.23053.1 -> To Version 1.0.0-beta.23060.3 (parent: Microsoft.DotNet.Arcade.Sdk

…113.7 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.XUnitExtensions From Version 8.0.0-beta.23054.2 -> To Version 8.0.0-beta.23063.7 Dependency coherency updates Microsoft.DotNet.XliffTasks From Version 1.0.0-beta.23053.1 -> To Version 1.0.0-beta.23062.1 (parent: Microsoft.DotNet.Arcade.Sdk

ViktorHofer · 2023-01-16T15:18:35Z

The remaining are NativeAOT related:

      "C:\h\w\A698091D\t\dotnetSdkTests\wmrk43qu.2yh\TrimmingOptio---F18EF6A1\HelloWorld\HelloWorld.csproj" (Publish target) (1:7) ->
      (_ComputeAssembliesToCompileToNative target) -> 
        C:\h\w\A698091D\t\dotnetSdkTests\wmrk43qu.2yh\.nuget\packages\microsoft.dotnet.ilcompiler\8.0.0-alpha.1.23058.2\build\Microsoft.NETCore.Native.Publish.targets(67,5): error : Native compilation can run on x64 and arm64 hosts only. [C:\h\w\A698091D\t\dotnetSdkTests\wmrk43qu.2yh\TrimmingOptio---F18EF6A1\HelloWorld\HelloWorld.csproj]
      
          0 Warning(s)
          1 Error(s)

@LakshanF @MichalStrehovsky can you please take a look?

…116.1 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.XUnitExtensions From Version 8.0.0-beta.23054.2 -> To Version 8.0.0-beta.23066.1 Dependency coherency updates Microsoft.DotNet.XliffTasks From Version 1.0.0-beta.23053.1 -> To Version 1.0.0-beta.23064.1 (parent: Microsoft.DotNet.Arcade.Sdk

…117.5 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.XUnitExtensions From Version 8.0.0-beta.23054.2 -> To Version 8.0.0-beta.23067.5 Dependency coherency updates Microsoft.DotNet.XliffTasks From Version 1.0.0-beta.23053.1 -> To Version 1.0.0-beta.23066.1 (parent: Microsoft.DotNet.Arcade.Sdk

ViktorHofer · 2023-01-18T15:23:17Z

@jkotas @sbomer @LakshanF we are still seeing tests failures related to NativeAOT publishing. Can you please take a look?

Unix is passed in as the TargetOS instead of Linux for the leg. I believe that's because of the use of the $(OS) property here which returns Unix on non Windows and non OSX platforms: https://github.com/dotnet/runtime/blob/0e77e6b90bd215c1a7c5c92283f5d2d6238871b7/src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.targets#L32

That regressed with this change: dotnet/runtime@4ece8f0 which started passing the TargetOS value to ILC.

ViktorHofer · 2023-01-18T15:40:52Z

src/Layout/toolset-tasks/OverrideAndCreateBundledNETCoreAppPackageVersion.cs

+            CheckAndReplaceAttribute(itemGroup
+                .Elements(ns + "KnownILCompilerPack").First().Attribute("ILCompilerPackVersion"));


dotnet/sdk tests were running against the LKG ILCompiler instead of the dependency from dotnet/runtime which is why we are seeing ILCompiler failures only in this PR. This fixes that. cc @sbomer

Thanks for fixing this!

jkotas · 2023-01-18T16:50:51Z

That regressed with this change: dotnet/runtime@4ece8f0 which started passing the TargetOS value to ILC.

#80791

Thank you for root causing the problem!

ghost added the Area-Infrastructure label Jan 6, 2023

dotnet-maestro bot added 3 commits January 6, 2023 19:37

nagilson enabled auto-merge January 10, 2023 17:22

nagilson approved these changes Jan 10, 2023

View reviewed changes

dotnet-maestro bot and others added 3 commits January 13, 2023 09:50

Remove KnownILLinkPack addition

57a6962

ViktorHofer approved these changes Jan 16, 2023

View reviewed changes

Fix-up WPF .NET Framework test

fb6548e

ViktorHofer mentioned this pull request Jan 17, 2023

It_builds_successfully_when_targeting_net_framework test wants to compile a .NETCoreApp template on .NET Framework #29968

Open

ViktorHofer and others added 2 commits January 17, 2023 12:55

Disable It_builds_successfully_when_targeting_net_framework netfx test

8fe5ed8

jkotas mentioned this pull request Jan 17, 2023

Default to ILC host architecture that matches OS architecture on Windows dotnet/runtime#80752

Merged

ViktorHofer added 6 commits January 18, 2023 11:39

Update OverrideAndCreateBundledNETCoreAppPackageVersion.cs

d7ba1e3

Update OverlaySdkOnLKG.targets

f292aef

Update OverrideAndCreateBundledNETCoreAppPackageVersion.cs

5e88846

Update OverrideAndCreateBundledNETCoreAppPackageVersion.cs

4277688

Update OverlaySdkOnLKG.targets

7be4433

Update OverrideAndCreateBundledNETCoreAppPackageVersion.cs

7c1d5ef

ViktorHofer and others added 4 commits January 18, 2023 11:52

Update OverrideAndCreateBundledNETCoreAppPackageVersion.cs

025dec8

Update OverrideAndCreateBundledNETCoreAppPackageVersion.cs

46f20a7

Update OverrideAndCreateBundledNETCoreAppPackageVersion.cs

eb0456b

ViktorHofer approved these changes Jan 18, 2023

View reviewed changes

ViktorHofer reviewed Jan 18, 2023

View reviewed changes

jkotas mentioned this pull request Jan 18, 2023

Partial revert of #71486 to unblock dotnet/sdk dotnet/runtime#80791

Merged

jkotas mentioned this pull request Jan 18, 2023

NativeAOT for FreeBSD dotnet/runtime#80323

Merged

MichalStrehovsky mentioned this pull request Jan 19, 2023

Fix TargetOS value linux instead of Unix dotnet/runtime#80794

Merged

ViktorHofer closed this Jan 19, 2023

auto-merge was automatically disabled January 19, 2023 13:00
Pull request was closed

ViktorHofer reopened this Jan 19, 2023

dotnet-maestro bot merged commit 9fbe017 into main Jan 19, 2023

dotnet-maestro bot deleted the darc-main-48e20b95-06ab-4001-afe7-77ff5480cb9f branch January 19, 2023 14:30

jkotas mentioned this pull request Feb 24, 2023

Replace IlcHostArch with SDK-computed value dotnet/runtime#82645

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[main] Update dependencies from dotnet/arcade#29800

[main] Update dependencies from dotnet/arcade#29800
dotnet-maestro[bot] merged 22 commits intomainfrom
darc-main-48e20b95-06ab-4001-afe7-77ff5480cb9f

dotnet-maestro bot commented Jan 6, 2023 •

edited

Loading

Uh oh!

nagilson commented Jan 9, 2023

Uh oh!

nagilson commented Jan 10, 2023

Uh oh!

azure-pipelines bot commented Jan 10, 2023

Uh oh!

nagilson commented Jan 12, 2023

Uh oh!

ViktorHofer commented Jan 13, 2023

Uh oh!

ViktorHofer commented Jan 16, 2023 •

edited

Loading

Uh oh!

ViktorHofer commented Jan 18, 2023 •

edited

Loading

Uh oh!

ViktorHofer Jan 18, 2023

Uh oh!

sbomer Jan 18, 2023

Uh oh!

jkotas commented Jan 18, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

		CheckAndReplaceAttribute(itemGroup
		.Elements(ns + "KnownILCompilerPack").First().Attribute("ILCompilerPackVersion"));

Conversation

dotnet-maestro bot commented Jan 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coherency Updates

From https://github.com/dotnet/arcade

Uh oh!

nagilson commented Jan 9, 2023

Uh oh!

nagilson commented Jan 10, 2023

Uh oh!

azure-pipelines bot commented Jan 10, 2023

Uh oh!

nagilson commented Jan 12, 2023

Uh oh!

ViktorHofer commented Jan 13, 2023

Uh oh!

ViktorHofer commented Jan 16, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ViktorHofer commented Jan 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ViktorHofer Jan 18, 2023

Choose a reason for hiding this comment

Uh oh!

sbomer Jan 18, 2023

Choose a reason for hiding this comment

Uh oh!

jkotas commented Jan 18, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

dotnet-maestro bot commented Jan 6, 2023 •

edited

Loading

ViktorHofer commented Jan 16, 2023 •

edited

Loading

ViktorHofer commented Jan 18, 2023 •

edited

Loading