Update Microsoft.NET.ApiCompat.targets for net8.0#29450
Merged
SteveSandersonMS merged 1 commit intomainfrom Dec 9, 2022
Merged
Update Microsoft.NET.ApiCompat.targets for net8.0#29450SteveSandersonMS merged 1 commit intomainfrom
SteveSandersonMS merged 1 commit intomainfrom
Conversation
This was referenced Dec 8, 2022
Member
Author
|
You might want to use some MSBuild property to get the current target TFM instead of hardcoding |
wtgodbe
approved these changes
Dec 8, 2022
Member
wtgodbe
left a comment
There was a problem hiding this comment.
@dsplaisted @marcpopMSFT any reason we shouldn't take this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks like there's now an incorrect path inside
Microsoft.NET.ApiCompat.targets, and it's blocking theaspnetcorerepo from ingesting SDK updates (dotnet/aspnetcore#44925).