Fix TargetPlatformVersion normalization for Windows#29009
Merged
dsplaisted merged 9 commits intodotnet:release/7.0.2xxfrom Nov 15, 2022
Merged
Fix TargetPlatformVersion normalization for Windows#29009dsplaisted merged 9 commits intodotnet:release/7.0.2xxfrom
dsplaisted merged 9 commits intodotnet:release/7.0.2xxfrom
Conversation
…013.4 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.XUnitExtensions From Version 7.0.0-beta.22511.2 -> To Version 7.0.0-beta.22513.4
…014.3 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.XUnitExtensions From Version 7.0.0-beta.22511.2 -> To Version 7.0.0-beta.22514.3
…031.4 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.XUnitExtensions From Version 7.0.0-beta.22511.2 -> To Version 7.0.0-beta.22531.4
…107.1 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.XUnitExtensions From Version 7.0.0-beta.22511.2 -> To Version 7.0.0-beta.22557.1
…108.4 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.XUnitExtensions From Version 7.0.0-beta.22511.2 -> To Version 7.0.0-beta.22558.4
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
48d4e91 to
c610765
Compare
nagilson
reviewed
Nov 11, 2022
7e7930d to
b0d6e99
Compare
joeloff
reviewed
Nov 11, 2022
Member
Author
|
FYI @j0shuams |
This broke with changes related to dotnet#27199. It's now possible to have multiple supported platform version items for the same version.
Depending on whether we're using preview versions, some of the packages may be downloaded by NuGet and have lowercased names, while at other times they may be shipped in the packs folder and have mixed case.
b0d6e99 to
91b88f3
Compare
Member
Author
|
This was rejected for servicing as the customer impact is low to nonexistent, so I've re-targeted it to 7.0.2xx. |
Member
Author
|
@nagilson Care to review this so we can merge it now? |
nagilson
approved these changes
Nov 14, 2022
Member
There was a problem hiding this comment.
@dsplaisted I looked at the code and it seemed good, but I didn't see any test that tested this specific regression:
A TargetPlatformVersion property for Windows without a trailing “.0” won’t be normalized to 4 version sections anymore (for example from 10.0.18362 to 10.0.18362.0). Am I wrong that this is related to that?
The test changes I saw were just handling case-sensitivity, was a regression test added to check for the .0 behavior? I know some other tests (might) fail if it's wrong already.
Member
Author
Member
|
Gotcha, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This broke with #27199