Introduce PublishRuntimeIdentifier#28717
Merged
nagilson merged 21 commits intodotnet:release/7.0.2xxfrom Nov 4, 2022
Merged
Conversation
dsplaisted
reviewed
Oct 26, 2022
2 tasks
Member
Author
|
@dsplaisted PTAL when you're free |
dsplaisted
reviewed
Oct 31, 2022
src/Tests/Microsoft.NET.Publish.Tests/RuntimeIdentifiersTests.cs
Outdated
Show resolved
Hide resolved
src/Tests/Microsoft.NET.Publish.Tests/RuntimeIdentifiersTests.cs
Outdated
Show resolved
Hide resolved
src/Tests/Microsoft.NET.Publish.Tests/RuntimeIdentifiersTests.cs
Outdated
Show resolved
Hide resolved
src/Tests/Microsoft.NET.Publish.Tests/RuntimeIdentifiersTests.cs
Outdated
Show resolved
Hide resolved
src/Tests/Microsoft.NET.Publish.Tests/RuntimeIdentifiersTests.cs
Outdated
Show resolved
Hide resolved
src/Tests/Microsoft.NET.Publish.Tests/RuntimeIdentifiersTests.cs
Outdated
Show resolved
Hide resolved
src/Tests/Microsoft.NET.Publish.Tests/RuntimeIdentifiersTests.cs
Outdated
Show resolved
Hide resolved
src/Tests/Microsoft.NET.Publish.Tests/RuntimeIdentifiersTests.cs
Outdated
Show resolved
Hide resolved
This reverts commit c6dbb25.
Co-authored-by: Daniel Plaisted <dsplaisted@gmail.com>
438d643 to
36c3bc6
Compare
Member
Author
|
/azp run (GH is bugged due to rebase) |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
No pipelines are associated with this pull request. |
Member
Author
|
@dsplaisted PTAL. I've made all of the requested changes and a few others where the same comment applied to other parts. Let's merge this and then use this testProject change in the PublishSelfContained PR. |
dsplaisted
approved these changes
Nov 2, 2022
src/Tests/Microsoft.NET.Publish.Tests/RuntimeIdentifiersTests.cs
Outdated
Show resolved
Hide resolved
src/Tests/Microsoft.NET.Publish.Tests/RuntimeIdentifiersTests.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Daniel Plaisted <dsplaisted@gmail.com>
Member
Author
|
@dsplaisted Thanks for taking a look, I appreciate your time. I added some comments in the test code. As incorrect comments can be quite insidious, lmk if you see anything wrong. |
dsplaisted
approved these changes
Nov 3, 2022
src/Tests/Microsoft.NET.TestFramework/ProjectConstruction/TestProject.cs
Outdated
Show resolved
Hide resolved
src/Tests/Microsoft.NET.TestFramework/ProjectConstruction/TestProject.cs
Outdated
Show resolved
Hide resolved
src/Tests/Microsoft.NET.TestFramework/ProjectConstruction/TestProject.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Daniel Plaisted <dsplaisted@gmail.com>
Co-authored-by: Daniel Plaisted <dsplaisted@gmail.com>
…into nagilson-publish-rid
dsplaisted
approved these changes
Nov 4, 2022
src/Tests/Microsoft.NET.TestFramework/ProjectConstruction/TestProject.cs
Outdated
Show resolved
Hide resolved
… anyways Co-authored-by: Daniel Plaisted <dsplaisted@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes Examples
dotnet publish --use-current-runtime -p:PublishRuntimeIdentifier=tizenwill publish with tizen, not the ucr.dotnet publish --self-contained -p:PublishRuntimeIdentifier=win-x86will publish with rid: win-x86dotnet publish -p:PublishRuntimeIdentifier=win-x86will publish with win-x86 rid.In a project file:
dotnet build-> win-x86 rid.dotnet publish-> win-x64 rid.dotnet publish -r win-x86 /p:PublishRuntimeIdentifier=tizenwill get rid: win-x86. Not ideal, we can do it the other way but it will have potentially far-reaching consequences.dotnet publish --property:RuntimeIdentifier=win-x86 /p:PublishRuntimeIdentifier=tizen: gives win-x86 rid.Summary
PublishRuntimeIdentifierwill overrideRuntimeIdentifierwhen publishing unless it is global, like passed in withdotnet publish --r RID /p:PulishRuntimeIdentifier=RID_2PublishRuntimeIdentifierwill override the RID if UCR is used.The rest is pretty self explanatory...