Make all public API in dotnet-watch.dll internal and sealed.#28260
Merged
tmat merged 7 commits intodotnet:mainfrom Nov 22, 2022
Merged
Make all public API in dotnet-watch.dll internal and sealed.#28260tmat merged 7 commits intodotnet:mainfrom
tmat merged 7 commits intodotnet:mainfrom
Conversation
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
2 tasks
....DotNet.Common.ItemTemplates/content/Nuget/.template.config/localize/templatestrings.cs.json
Show resolved
Hide resolved
vlada-shubina
previously requested changes
Oct 18, 2022
Member
vlada-shubina
left a comment
There was a problem hiding this comment.
Please avoid changes in templates as this PR is not related to them.
2 tasks
Member
vlada-shubina
left a comment
There was a problem hiding this comment.
Looks good from templating perspective
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
dotnet-watch.dll has been intended to be used as a tool, not consumed as a library and expose any extensibility points via public APIs.
Member
Author
|
@javiercn PTAL |
javiercn
approved these changes
Nov 22, 2022
Member
javiercn
left a comment
There was a problem hiding this comment.
Looks correct from what I can tell.
Are these APIs used by VS in some way?
Member
Author
No, VS doesn't use dotnet-watch at all. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dotnet-watch.dll has been intended to be used as a tool, not consumed as a library and expose any extensibility points via public APIs.