Conversation
8 tasks
ce6896f to
f864b86
Compare
aortiz-msft
approved these changes
Sep 15, 2022
Contributor
aortiz-msft
left a comment
There was a problem hiding this comment.
LGTM but we may need eyes from @marcpopMSFT or someone in his team.
Member
|
@aortiz-msft I mean, I was hoping your team would own these PRs end to end so my team didn't have to review/merge them. Other teams that contribute to the sdk repo tend to manage their own code as it's gotten too big for my team to track it all (there are 10+ teams making changes). The PR looks fine to me other than what branch it should go into as this is going into 8.0.1xx. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the August 2022 CTL update from the Microsoft Trusted Root Program team.
Previously, codesignctl.pem contained roots which were valid for both code signing (CS) and timestamping (TS), which means that roots valid for one but not the other were not included.
With this PR, there are separate CS and TS certificate bundles, which contain all roots valid for that purpose.
CC @richlander, @aortiz-msft