Enable signature checks in the package downloader#25395
Merged
Conversation
Member
Author
|
Some additional tests are pending until dotnet/runtime-assets#242 makes its way through the official CI build and we have a new test asset package available. Most of the testing remains manual because it requires a properly signed copy of dotnet. |
marcpopMSFT
approved these changes
May 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #25377
The simple fix is to just pass
VerifySignatureswhenever a workload command instantiatesNuGetPackageDownloader. That still leaves the risk of adding a new command and not passing it through in the future. Instead, all of that code was moved to theWorkloadCommandBaseso that commands don't duplicate this.In doing so I uncovered a number of other inconsistencies around the package download folders that vary significantly between commands and because the downloader depends on these values, it also needed to be refactored.