Add tool install implicit RIDs#22331
Conversation
eb504be to
bf13ca3
Compare
bf13ca3 to
b1e20fd
Compare
|
@joeloff I think this is the minimal change to get implicit arch targeting working, but we're still using the tmp project restore package download strategy instead of using the new PackageDownloader. I'd like to look into cleaning that up, so I've filed an issue: #22349. I've targeted it to 6.0.2xx for now, not sure if that's realistic as this could be a big change and will touch sensitive code (FYI @marcpopMSFT) |
dsplaisted
left a comment
There was a problem hiding this comment.
It looks like we don't have any tests for the arm64 / x64 logic this is adding. Is it possible to add tests for that?
Also check with @richlander that this is still the logic that we want.
src/Cli/dotnet/commands/dotnet-tool/install/ToolInstallGlobalOrToolPathCommand.cs
Show resolved
Hide resolved
77bee74 to
10a98a8
Compare
10a98a8 to
febe712
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@dsplaisted I've been seeing the darwin leg timing out repeatedly, is this one of the infrastructure issues you had to fix in the branding PR? |
No, this doesn't look like the same failure. The one I hit wasn't even successfully building, where here it looks like the test run is timing out. |
Fixes #21660