Add self contained short flag#19681
Add self contained short flag#19681wli3 merged 3 commits intodotnet:release/6.0.1xxfrom WeihanLi:feature/self-contained-short-flag
Conversation
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
|
Love it. When we merge this, we should also add support an implicit RID at the same time. That will make the feature from good to great. /cc @agocke |
|
I think we just need a few tests here. There are some existing tests in |
Great thanks @agocke, would add some test cases |
src/Tests/dotnet-publish.Tests/GivenDotnetPublishPublishesProjects.cs
Outdated
Show resolved
Hide resolved
src/Tests/dotnet-publish.Tests/GivenDotnetPublishPublishesProjects.cs
Outdated
Show resolved
Hide resolved
|
@richlander Any more comments? |
|
Also @wli3 in-case I'm missing anything |
|
@KathleenDollard could you double check that? We need to be careful adding new short hands, since we have only 26 letters to use |
|
it is good on the technical side |
|
Unfortunately, We avoid having the same abbreviation mean different things, especially for closely related commands. And we work hard to have consistent abbreviations where a particular option is available. Since |
|
I think there is no choice but to abbreviate this as |
|
We could do |
|
I still want to hold on this change until we add an implicit RID by default. |
Is there a way to do that based on what it detects on the os and what cpu bitness it detects as well? |
|
Thanks, will update to @richlander as for the default implicit RID, I'm going to implement it in another PR #19725, I'm not sure about the changes, maybe @agocke could help? |
|
FYI @KathleenDollard is not available today. |
|
Got @KathleenDollard's signoff offline. @wli3 , anything else before we approve and merge? |
|
Is this ready to merge yet? |
#19576
Add
--scshort for--self-contained