SDK support for runtime native host and COM changes #17657
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
vitek-karas
approved these changes
May 17, 2021
eerhardt
reviewed
May 17, 2021
src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.ILLink.targets
Outdated
Show resolved
Hide resolved
sbomer
approved these changes
May 17, 2021
mateoatr
approved these changes
May 17, 2021
eerhardt
reviewed
May 17, 2021
src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.targets
Outdated
Show resolved
Hide resolved
eerhardt
approved these changes
May 18, 2021
Member
eerhardt
left a comment
There was a problem hiding this comment.
LGTM.
We should be careful about merging this in preview5. The runtime still needs to be updated with the new names. If this change went into preview5, but the corresponding runtime change didn't, we would have mis-matches.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SDK property support for the native host (IJW & Managed Component) feature switches. Also fixed name changes for the COM feature switch