Add new properties for analyzer#16098
Merged
tlakollo merged 7 commits intodotnet:masterfrom Mar 10, 2021
Merged
Conversation
sbomer
reviewed
Mar 1, 2021
src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.Analyzers.targets
Outdated
Show resolved
Hide resolved
src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.Analyzers.targets
Outdated
Show resolved
Hide resolved
Reorg properties so they can use info not set in these targets
sbomer
reviewed
Mar 2, 2021
src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.Analyzers.targets
Outdated
Show resolved
Hide resolved
src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.Analyzers.targets
Outdated
Show resolved
Hide resolved
src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.Analyzers.targets
Outdated
Show resolved
Hide resolved
Member
|
Thinking about the naming - I wonder if they should be called @samsp-msft do you have any feedback on the new property names? (context: they are used to enable the Roslyn single-file/trim analysis even if not using PublishSingleFile/PublishTrimmed.) |
Contributor
Author
|
I was thinking that might be good to stick to naming like |
Member
|
I like the singular |
sbomer
approved these changes
Mar 9, 2021
src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.Analyzers.targets
Outdated
Show resolved
Hide resolved
src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.Analyzers.targets
Outdated
Show resolved
Hide resolved
src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.Analyzers.targets
Outdated
Show resolved
Hide resolved
added 2 commits
March 9, 2021 15:46
… into NewAnalyzerProperties
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a layer of indirection for enabling the analyzer. By using AnalyzeSingleFile and AnalyzeTrimming we open up the usage of the analyzer for other platforms. For example, Xamarin doesn't use the flag PublishSingleFile but could set AnalyzeSingleFile to run the analyzer.