Adding OR_GREATER preprocessor symbols#14798
Merged
sfoslund merged 2 commits intodotnet:release/5.0.2xxfrom Dec 3, 2020
Merged
Adding OR_GREATER preprocessor symbols#14798sfoslund merged 2 commits intodotnet:release/5.0.2xxfrom
sfoslund merged 2 commits intodotnet:release/5.0.2xxfrom
Conversation
dsplaisted
requested changes
Dec 2, 2020
Member
dsplaisted
left a comment
There was a problem hiding this comment.
I think per the spec we don't want to add any new compilation constants for the platform.
Also, let's try to target this for 5.0.2xx. No need for this to wait until .NET 6.
src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.BeforeCommon.targets
Outdated
Show resolved
Hide resolved
src/Tests/Microsoft.NET.Build.Tests/GivenThatWeWantToBuildALibrary.cs
Outdated
Show resolved
Hide resolved
src/Tests/Microsoft.NET.Build.Tests/GivenThatWeWantToBuildALibraryWithFSharp.cs
Outdated
Show resolved
Hide resolved
src/Tests/Microsoft.NET.Build.Tests/GivenThatWeWantToBuildALibraryWithFSharp.cs
Outdated
Show resolved
Hide resolved
src/Tests/Microsoft.NET.Build.Tests/GivenThatWeWantToBuildALibraryWithVB.cs
Outdated
Show resolved
Hide resolved
3feb968 to
7d56ddc
Compare
Contributor
|
Hey folks, any specific reason why nuget-team was added? |
Member
Author
|
@aortiz-msft false alarm, it was it was triggered while retargeting the PR, no need to review. |
7d56ddc to
6cac00c
Compare
dsplaisted
approved these changes
Dec 3, 2020
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14540