-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Global tool .cmd shims will show "Terminate Batch Job" prompt on CTRL+C #49662
Copy link
Copy link
Open
Labels
Area-Toolsgood first issueIssues that would be a good fit for someone new to the repository. Narrow in scope, well-defined.Issues that would be a good fit for someone new to the repository. Narrow in scope, well-defined.untriagedRequest triage from a team memberRequest triage from a team member
Milestone
Description
On Windows, for tools where the runner type is executable, we create a .cmd script shim that invokes the tool. The shim goes in the dotnet tools folder which is on the path.
Unfortunately, batch files like this will generate an extra Terminate batch job (Y/N) prompt when CTRL+C is pressed. We ran into this for dnx in #49623.
We should probably generate both a PowerShell and a .cmd shell shim script, so that for users of PowerShell, that script will be preferred and they won't get the extra termination prompt when CTRL+C is pressed.
The logic to create the script is in the ShellShimRepository class.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Area-Toolsgood first issueIssues that would be a good fit for someone new to the repository. Narrow in scope, well-defined.Issues that would be a good fit for someone new to the repository. Narrow in scope, well-defined.untriagedRequest triage from a team memberRequest triage from a team member