Fix error display by ensuring GetManifests is called before checking error state

Copilot · marcpopMSFT · Copilot · commit b32666d9de09 · 2026-01-08T23:53:48.000Z
- ShowWorkloadsInfo now calls GetManifests() before checking error message
- This ensures _exceptionToThrow is populated when manifests from workload set are missing
- Changed InitializeManifests to always throw if error exists (not just when no manifests loaded)
- Fixed redundant error message display logic
- Error now properly shown in dotnet --info and dotnet workload --info

Co-authored-by: marcpopMSFT &lt;12663534+marcpopMSFT@users.noreply.github.com&gt;
diff --git a/src/Cli/dotnet/Commands/Workload/WorkloadInfoHelper.cs b/src/Cli/dotnet/Commands/Workload/WorkloadInfoHelper.cs
@@ -124,14 +124,25 @@ internal void ShowWorkloadsInfo(IReporter? reporter = null, string? dotnetDir =
     {
         reporter ??= Reporter.Output;
         
-        var versionInfo = ManifestProvider.GetWorkloadVersion();
-        
         // Get the error message if manifests are missing
+        // We need to call GetManifests() first to ensure _exceptionToThrow is populated
+        // if manifests from a workload set are missing
         string? manifestError = null;
         if (ManifestProvider is SdkDirectoryWorkloadManifestProvider sdkProvider)
         {
+            // Calling GetManifests().Count() forces enumeration which populates the error state
+            try
+            {
+                _ = ManifestProvider.GetManifests().Count();
+            }
+            catch
+            {
+                // Ignore errors here - we'll get the message via GetManifestErrorMessage
+            }
             manifestError = sdkProvider.GetManifestErrorMessage();
         }
+        
+        var versionInfo = ManifestProvider.GetWorkloadVersion();
 
         void WriteUpdateModeAndAnyError(string indent = "")
         {
@@ -153,9 +164,9 @@ void WriteUpdateModeAndAnyError(string indent = "")
                 {
                     reporter.WriteLine(indent + string.Format(CliCommandStrings.WorkloadSetFromGlobalJsonNotInstalled, versionInfo.Version, versionInfo.GlobalJsonPath));
                 }
-                else
+                else if (manifestError == null)
                 {
-                    // Workload set is installed but manifests are missing
+                    // Workload set is installed but manifests are missing - only show generic message if we don't have a specific error
                     reporter.WriteLine(indent + CliCommandStrings.WorkloadsNotInstalledRunWorkloadUpdate);
                 }
             }
diff --git a/src/Resolvers/Microsoft.NET.Sdk.WorkloadManifestReader/WorkloadResolver.cs b/src/Resolvers/Microsoft.NET.Sdk.WorkloadManifestReader/WorkloadResolver.cs
@@ -85,15 +85,15 @@ private void InitializeManifests()
             {
                 LoadManifestsFromProvider(_manifestProvider);
                 
-                // If manifests from a workload set are missing, check if we got an error
-                // This will be shown when trying to use workloads but manifests are not available
+                // If manifests from a workload set are missing, throw the error when trying to use workloads
+                // This ensures errors are shown when building apps that require workloads
                 if (_manifestProvider is SdkDirectoryWorkloadManifestProvider sdkProvider)
                 {
                     var manifestError = sdkProvider.GetManifestErrorMessage();
-                    if (manifestError != null && _manifests.Count == 0)
+                    if (manifestError != null)
                     {
-                        // No manifests were loaded and there's an error - this means workloads won't work
-                        // Throw the error so users know what's wrong
+                        // There's an error with missing manifests from a workload set
+                        // Throw it so users know what's wrong
                         throw new FileNotFoundException(manifestError);
                     }
                 }

Original file line number	Diff line number	Diff line change
`@@ -124,14 +124,25 @@ internal void ShowWorkloadsInfo(IReporter? reporter = null, string? dotnetDir =`
`124`	`124`	`{`
`125`	`125`	`reporter ??= Reporter.Output;`
`126`	`126`
`127`		`- var versionInfo = ManifestProvider.GetWorkloadVersion();`
`128`		`-`
`129`	`127`	`// Get the error message if manifests are missing`
	`128`	`+ // We need to call GetManifests() first to ensure _exceptionToThrow is populated`
	`129`	`+ // if manifests from a workload set are missing`
`130`	`130`	`string? manifestError = null;`
`131`	`131`	`if (ManifestProvider is SdkDirectoryWorkloadManifestProvider sdkProvider)`
`132`	`132`	`{`
	`133`	`+ // Calling GetManifests().Count() forces enumeration which populates the error state`
	`134`	`+ try`
	`135`	`+ {`
	`136`	`+ _ = ManifestProvider.GetManifests().Count();`
	`137`	`+ }`
	`138`	`+ catch`
	`139`	`+ {`
	`140`	`+ // Ignore errors here - we'll get the message via GetManifestErrorMessage`
	`141`	`+ }`
`133`	`142`	`manifestError = sdkProvider.GetManifestErrorMessage();`
`134`	`143`	`}`
	`144`	`+`
	`145`	`+ var versionInfo = ManifestProvider.GetWorkloadVersion();`
`135`	`146`
`136`	`147`	`void WriteUpdateModeAndAnyError(string indent = "")`
`137`	`148`	`{`
`@@ -153,9 +164,9 @@ void WriteUpdateModeAndAnyError(string indent = "")`
`153`	`164`	`{`
`154`	`165`	`reporter.WriteLine(indent + string.Format(CliCommandStrings.WorkloadSetFromGlobalJsonNotInstalled, versionInfo.Version, versionInfo.GlobalJsonPath));`
`155`	`166`	`}`
`156`		`- else`
	`167`	`+ else if (manifestError == null)`
`157`	`168`	`{`
`158`		`- // Workload set is installed but manifests are missing`
	`169`	`+ // Workload set is installed but manifests are missing - only show generic message if we don't have a specific error`
`159`	`170`	`reporter.WriteLine(indent + CliCommandStrings.WorkloadsNotInstalledRunWorkloadUpdate);`
`160`	`171`	`}`
`161`	`172`	`}`
Original file line number	Diff line number	Diff line change
`@@ -85,15 +85,15 @@ private void InitializeManifests()`
`85`	`85`	`{`
`86`	`86`	`LoadManifestsFromProvider(_manifestProvider);`
`87`	`87`
`88`		`- // If manifests from a workload set are missing, check if we got an error`
`89`		`- // This will be shown when trying to use workloads but manifests are not available`
	`88`	`+ // If manifests from a workload set are missing, throw the error when trying to use workloads`
	`89`	`+ // This ensures errors are shown when building apps that require workloads`
`90`	`90`	`if (_manifestProvider is SdkDirectoryWorkloadManifestProvider sdkProvider)`
`91`	`91`	`{`
`92`	`92`	`var manifestError = sdkProvider.GetManifestErrorMessage();`
`93`		`- if (manifestError != null && _manifests.Count == 0)`
	`93`	`+ if (manifestError != null)`
`94`	`94`	`{`
`95`		`- // No manifests were loaded and there's an error - this means workloads won't work`
`96`		`- // Throw the error so users know what's wrong`
	`95`	`+ // There's an error with missing manifests from a workload set`
	`96`	`+ // Throw it so users know what's wrong`
`97`	`97`	`throw new FileNotFoundException(manifestError);`
`98`	`98`	`}`
`99`	`99`	`}`