Updates per code review feedback

MichaelSimons · MichaelSimons · commit 5290ff07bf27 · 2025-03-28T21:47:29.000Z
diff --git a/src/SourceBuild/content/eng/tools/tasks/Microsoft.DotNet.UnifiedBuild.Tasks/WriteSbrpUsageReport.cs b/src/SourceBuild/content/eng/tools/tasks/Microsoft.DotNet.UnifiedBuild.Tasks/WriteSbrpUsageReport.cs
@@ -173,12 +173,12 @@ private void ScanProjectReferences()
 
             foreach (DownloadDependency downloadDep in lockFile.PackageSpec.TargetFrameworks.SelectMany(fx => fx.DownloadDependencies))
             {
-                TrackPackageReference(lockFile.Path, downloadDep.Name, downloadDep.VersionRange.MinVersion?.ToString(), null);
+                TrackPackageReference(lockFile.Path, downloadDep.Name, downloadDep.VersionRange.MinVersion?.ToString(), Enumerable.Empty<string>());
             }
         }
     }
 
-    private void TrackPackageReference(string lockFilePath, string? name, string? version, IEnumerable<string>? tfms)
+    private void TrackPackageReference(string lockFilePath, string? name, string? version, IEnumerable<string> tfms)
     {
         string id = PackageInfo.GetId(name, version);
         if (!_sbrpPackages.TryGetValue(id, out PackageInfo? info))
@@ -192,12 +192,9 @@ private void TrackPackageReference(string lockFilePath, string? name, string? ve
             info.References.Add(lockFilePath, referencedTfms);
         }
 
-        if (tfms != null)
+        foreach (string tfm in tfms)
         {
-            foreach (string tfm in tfms)
-            {
-                referencedTfms!.Add(tfm);
-            }
+            referencedTfms!.Add(tfm);
         }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -173,12 +173,12 @@ private void ScanProjectReferences()`
`173`	`173`
`174`	`174`	`foreach (DownloadDependency downloadDep in lockFile.PackageSpec.TargetFrameworks.SelectMany(fx => fx.DownloadDependencies))`
`175`	`175`	`{`
`176`		`- TrackPackageReference(lockFile.Path, downloadDep.Name, downloadDep.VersionRange.MinVersion?.ToString(), null);`
	`176`	`+ TrackPackageReference(lockFile.Path, downloadDep.Name, downloadDep.VersionRange.MinVersion?.ToString(), Enumerable.Empty<string>());`
`177`	`177`	`}`
`178`	`178`	`}`
`179`	`179`	`}`
`180`	`180`
`181`		`- private void TrackPackageReference(string lockFilePath, string? name, string? version, IEnumerable<string>? tfms)`
	`181`	`+ private void TrackPackageReference(string lockFilePath, string? name, string? version, IEnumerable<string> tfms)`
`182`	`182`	`{`
`183`	`183`	`string id = PackageInfo.GetId(name, version);`
`184`	`184`	`if (!_sbrpPackages.TryGetValue(id, out PackageInfo? info))`
`@@ -192,12 +192,9 @@ private void TrackPackageReference(string lockFilePath, string? name, string? ve`
`192`	`192`	`info.References.Add(lockFilePath, referencedTfms);`
`193`	`193`	`}`
`194`	`194`
`195`		`- if (tfms != null)`
	`195`	`+ foreach (string tfm in tfms)`
`196`	`196`	`{`
`197`		`- foreach (string tfm in tfms)`
`198`		`- {`
`199`		`- referencedTfms!.Add(tfm);`
`200`		`- }`
	`197`	`+ referencedTfms!.Add(tfm);`
`201`	`198`	`}`
`202`	`199`	`}`
`203`	`200`