Skip to content

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Feb 27, 2024

Backport of #98665 and #98824 to release/8.0-staging

/cc @MilenaHristova

Customer Impact

  • Customer reported
  • Found internally

[Select one or both of the boxes. Describe how this issue impacts customers, citing the expected and actual behaviors and scope of the issue. If customer-reported, provide the issue number.]

Regression

  • Yes
  • No

[If yes, specify when the regression was introduced. Provide the PR or commit if known.]

Testing

[How was the fix verified? How was the issue missed previously? What tests were added?]

Risk

[High/Medium/Low. Justify the indication by mentioning how risks were measured and addressed.]

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

@ghost
Copy link

ghost commented Feb 27, 2024

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #98665 to release/8.0-staging

/cc @MilenaHristova

Customer Impact

  • Customer reported
  • Found internally

[Select one or both of the boxes. Describe how this issue impacts customers, citing the expected and actual behaviors and scope of the issue. If customer-reported, provide the issue number.]

Regression

  • Yes
  • No

[If yes, specify when the regression was introduced. Provide the PR or commit if known.]

Testing

[How was the fix verified? How was the issue missed previously? What tests were added?]

Risk

[High/Medium/Low. Justify the indication by mentioning how risks were measured and addressed.]

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: -
Labels:

area-Infrastructure-libraries

Milestone: -

…lease (#98824)

* add metadata to manifest

* set in ItemDefinitionGroup

* remove from items

* comment
@carlossanlop
Copy link
Contributor

@ViktorHofer any chance you can take a look at this? Code Complete is on Monday March 11th, so if we want this included in the April Release, we should get this reviewed and merged before then.

@carlossanlop
Copy link
Contributor

BTW @MilenaHristova does this change generate new shipping assets? Asking because if that's the case, then we need to request Tactics approval. Otherwise, we can treat this as tell-mode.

Copy link
Member

@ViktorHofer ViktorHofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is tell-mode.

@MilenaHristova
Copy link
Contributor

BTW @MilenaHristova does this change generate new shipping assets? Asking because if that's the case, then we need to request Tactics approval. Otherwise, we can treat this as tell-mode.

No, it's a new way for the release infra to know which packages to ship, the set of shipping assets stays the same

@ViktorHofer ViktorHofer added the Servicing-approved Approved for servicing release label Mar 7, 2024
@ViktorHofer ViktorHofer merged commit db167d9 into release/8.0-staging Mar 7, 2024
@ViktorHofer ViktorHofer deleted the backport/pr-98665-to-release/8.0-staging branch March 7, 2024 12:35
@github-actions github-actions bot locked and limited conversation to collaborators Apr 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants