-
Notifications
You must be signed in to change notification settings - Fork 5.3k
[release/8.0-staging] Add ProducesNetCoreAssets property to Publishing.props #98988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/8.0-staging] Add ProducesNetCoreAssets property to Publishing.props #98988
Conversation
|
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries Issue DetailsBackport of #98665 to release/8.0-staging /cc @MilenaHristova Customer Impact
[Select one or both of the boxes. Describe how this issue impacts customers, citing the expected and actual behaviors and scope of the issue. If customer-reported, provide the issue number.] Regression
[If yes, specify when the regression was introduced. Provide the PR or commit if known.] Testing[How was the fix verified? How was the issue missed previously? What tests were added?] Risk[High/Medium/Low. Justify the indication by mentioning how risks were measured and addressed.] IMPORTANT: If this backport is for a servicing release, please verify that:
|
…lease (#98824) * add metadata to manifest * set in ItemDefinitionGroup * remove from items * comment
|
@ViktorHofer any chance you can take a look at this? Code Complete is on Monday March 11th, so if we want this included in the April Release, we should get this reviewed and merged before then. |
|
BTW @MilenaHristova does this change generate new shipping assets? Asking because if that's the case, then we need to request Tactics approval. Otherwise, we can treat this as tell-mode. |
ViktorHofer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is tell-mode.
No, it's a new way for the release infra to know which packages to ship, the set of shipping assets stays the same |
Backport of #98665 and #98824 to release/8.0-staging
/cc @MilenaHristova
Customer Impact
[Select one or both of the boxes. Describe how this issue impacts customers, citing the expected and actual behaviors and scope of the issue. If customer-reported, provide the issue number.]
Regression
[If yes, specify when the regression was introduced. Provide the PR or commit if known.]
Testing
[How was the fix verified? How was the issue missed previously? What tests were added?]
Risk
[High/Medium/Low. Justify the indication by mentioning how risks were measured and addressed.]
IMPORTANT: If this backport is for a servicing release, please verify that:
The PR target branch is
release/X.0-staging, notrelease/X.0.If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.